* Re: [PATCH] i2c: drivers: Remove superfluous error messages
@ 2020-05-04 12:30 Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-05-04 12:30 UTC (permalink / raw)
To: Aishwarya Ramakrishnan, linux-i2c, linux-arm-kernel
Cc: LKML, kernel-janitors, Andy Shevchenko, Baruch Siach,
Dejin Zheng, Dmitry Osipenko, Greg Kroah-Hartman,
Gregory Clement, Hans de Goede, Masahiro Yamada,
Pierre-Yves Mordret, Thomas Gleixner, Thor Thayer,
Vladimir Zapolskiy
> The function platform_get_irq can log an error by itself.
> This omit a redundant message for exception handling in the
> calling function.
I propose to avoid a typo in a word of this change description.
> Suggested by Coccinelle.
Can an information like the following be more helpful?
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
I observe that a command like “make COCCI=… M=drivers/i2c/busses/ coccicheck”
points only three source files out for further considerations
according to such a known transformation pattern in the software “Linux next-20200504”.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: drivers: Remove superfluous error messages
@ 2020-05-04 12:30 Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-05-04 12:30 UTC (permalink / raw)
To: Aishwarya Ramakrishnan, linux-i2c, linux-arm-kernel
Cc: LKML, kernel-janitors, Andy Shevchenko, Baruch Siach,
Dejin Zheng, Dmitry Osipenko, Greg Kroah-Hartman,
Gregory Clement, Hans de Goede, Masahiro Yamada,
Pierre-Yves Mordret, Thomas Gleixner, Thor Thayer,
Vladimir Zapolskiy
> The function platform_get_irq can log an error by itself.
> This omit a redundant message for exception handling in the
> calling function.
I propose to avoid a typo in a word of this change description.
> Suggested by Coccinelle.
Can an information like the following be more helpful?
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
I observe that a command like “make COCCI=… M=drivers/i2c/busses/ coccicheck”
points only three source files out for further considerations
according to such a known transformation pattern in the software “Linux next-20200504”.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-04 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 12:30 [PATCH] i2c: drivers: Remove superfluous error messages Markus Elfring
2020-05-04 12:30 Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®