From: Qian Cai <quic_qiancai@quicinc.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] software node: Skip duplicated software_node sysfs
Date: Fri, 5 Nov 2021 14:47:43 -0400 [thread overview]
Message-ID: <52df4a97-1132-d594-0180-132d0ca714d5@quicinc.com> (raw)
In-Reply-To: <CAHp75VcrWPdR8EVGpcsniQedT0J4X700N7thFs6+srTP1MTgwQ@mail.gmail.com>
On 11/1/21 7:51 PM, Andy Shevchenko wrote:
> No, it’s not so easy. What you are doing is a papering over the real issue
> which is the limitation of the firmware nodes to two. What we need is to
> drop the link from struct fwnode_handle, move it to upper layer and modify
> all fwnode ops to be used over the list of fwnode:s.
>
> XHCI driver and DWC3 are sharing the primary fwnode, but at the same time
> they wanted to have _different_ secondary ones when role is switched. This
> can’t be done in the current design. And here is the symptom what you got.
Andy, thanks for the pointers so far. I was able to trace
set_primary_fwnode() and set_secondary_fwnode().
Anyway, what's the "upper layer"? Is that "struct device" or "struct
swnode"? I suppose you meant:
- Remove "secondary" field from "struct fwnode_handle".
- Replace "fwnode" from "upper layer" with
"struct list_head fwnode_head;".
- Modify all functions in "software_node_ops" to use "fwnode_head".
Is that correct?
next prev parent reply other threads:[~2021-11-05 18:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 20:03 Qian Cai
[not found] ` <CAHp75VcrWPdR8EVGpcsniQedT0J4X700N7thFs6+srTP1MTgwQ@mail.gmail.com>
2021-11-02 8:28 ` Heikki Krogerus
2021-11-02 8:32 ` Heikki Krogerus
2021-11-02 14:17 ` Qian Cai
2021-11-02 19:44 ` Qian Cai
2021-11-02 20:20 ` Andy Shevchenko
2021-11-02 20:26 ` Andy Shevchenko
2021-11-05 18:47 ` Qian Cai [this message]
2021-11-05 19:39 ` Andy Shevchenko
2021-11-08 16:07 ` Qian Cai
2021-11-08 18:06 ` Andy Shevchenko
2021-11-09 4:43 ` Qian Cai
2021-11-09 15:23 ` Qian Cai
2021-11-16 3:54 ` Qian Cai
2021-11-16 16:29 ` Rafael J. Wysocki
2021-11-17 14:38 ` Qian Cai
2021-11-17 14:45 ` Rafael J. Wysocki
2021-11-17 16:18 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52df4a97-1132-d594-0180-132d0ca714d5@quicinc.com \
--to=quic_qiancai@quicinc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®