From: Qian Cai <quic_qiancai@quicinc.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>, <linux-usb@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH] software node: Skip duplicated software_node sysfs
Date: Tue, 9 Nov 2021 10:23:52 -0500 [thread overview]
Message-ID: <YYqSiMwfdYPwQb62@qian-HP-Z2-SFF-G5-Workstation> (raw)
In-Reply-To: <YYn8hpxxmAtw9z5S@qian-HP-Z2-SFF-G5-Workstation>
On Mon, Nov 08, 2021 at 11:43:54PM -0500, Qian Cai wrote:
> Then, which functions do you suggest to replace with
> fwnode_create_software_node()? In dwc3_host_init(),
>
> int dwc3_host_init(struct dwc3 *dwc)
> {
> ...
> xhci = platform_device_alloc("xhci-hcd", PLATFORM_DEVID_AUTO);
> ...
> ret = platform_device_add(xhci);
>
> I am wondering if that we could solve the problem by avoiding
> "xhci-hcd" string here which would unfortunately clash with
> xhci_plat_init() as mentioned before:
Okay, I suppose that name has to be "xhci-hcd" to match the dirver
name. Otherwise, the below path did not run to create "xhci-hcd"
either. I noticed that the regression was discussed a few months ago
and leave it as is.
https://lore.kernel.org/lkml/e9bc1397-99b7-a57e-4860-80d146848e2c@nxp.com/
Alternatively, we might revert the commit 434b73e61cc6
("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
started to use device_add_properties() in iort_named_component_init()
which probably does not look pretty either. I can't think of any other
ways to avoid refactoring at the moment.
>
> sysfs_create_link
> software_node_notify
> device_create_managed_software_node
> iort_named_component_init
> iort_iommu_configure_id
> acpi_dma_configure_id
> platform_dma_configure
> really_probe.part.0
> really_probe
> __driver_probe_device
> driver_probe_device
> __driver_attach
> bus_for_each_dev
> driver_attach
> bus_add_driver
> driver_register
> __platform_driver_register
> xhci_plat_init
> do_one_initcall
> kernel_init_freeable
> kernel_init
> ret_from_fork
next prev parent reply other threads:[~2021-11-09 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 20:03 Qian Cai
[not found] ` <CAHp75VcrWPdR8EVGpcsniQedT0J4X700N7thFs6+srTP1MTgwQ@mail.gmail.com>
2021-11-02 8:28 ` Heikki Krogerus
2021-11-02 8:32 ` Heikki Krogerus
2021-11-02 14:17 ` Qian Cai
2021-11-02 19:44 ` Qian Cai
2021-11-02 20:20 ` Andy Shevchenko
2021-11-02 20:26 ` Andy Shevchenko
2021-11-05 18:47 ` Qian Cai
2021-11-05 19:39 ` Andy Shevchenko
2021-11-08 16:07 ` Qian Cai
2021-11-08 18:06 ` Andy Shevchenko
2021-11-09 4:43 ` Qian Cai
2021-11-09 15:23 ` Qian Cai [this message]
2021-11-16 3:54 ` Qian Cai
2021-11-16 16:29 ` Rafael J. Wysocki
2021-11-17 14:38 ` Qian Cai
2021-11-17 14:45 ` Rafael J. Wysocki
2021-11-17 16:18 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYqSiMwfdYPwQb62@qian-HP-Z2-SFF-G5-Workstation \
--to=quic_qiancai@quicinc.com \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®