From: Allen Hubbe <Allen.Hubbe@emc.com>
To: linux-ntb@googlegroups.com
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>
Subject: [PATCH v3 05/18] NTB: Check the device ID to set errata flags
Date: Tue, 9 Jun 2015 05:44:32 -0400 [thread overview]
Message-ID: <530e415992e4c4e23831bfbdf7b25cca1811378d.1433838377.git.Allen.Hubbe@emc.com> (raw)
In-Reply-To: <cover.1433838377.git.Allen.Hubbe@emc.com>
In-Reply-To: <cover.1433838377.git.Allen.Hubbe@emc.com>
From: Dave Jiang <dave.jiang@intel.com>
Set errata flags for the specific device IDs to which they apply,
instead of the whole xeon hardware class.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/ntb/hw/intel/ntb_hw_intel.c | 49 +++++++++++++++++++++++++++++++++----
1 file changed, 44 insertions(+), 5 deletions(-)
diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
index 64ce690d9616..3686ac1a3ee2 100644
--- a/drivers/ntb/hw/intel/ntb_hw_intel.c
+++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
@@ -1719,29 +1719,68 @@ static int snb_init_dev(struct intel_ntb_dev *ndev)
u8 ppd;
int rc, mem;
+ pdev = ndev_pdev(ndev);
+
+ switch (pdev->device) {
/* There is a Xeon hardware errata related to writes to SDOORBELL or
* B2BDOORBELL in conjunction with inbound access to NTB MMIO Space,
* which may hang the system. To workaround this use the second memory
* window to access the interrupt and scratch pad registers on the
* remote system.
*/
- ndev->hwerr_flags |= NTB_HWERR_SDOORBELL_LOCKUP;
+ case PCI_DEVICE_ID_INTEL_NTB_SS_JSF:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_JSF:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_JSF:
+ case PCI_DEVICE_ID_INTEL_NTB_SS_SNB:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_SNB:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_SNB:
+ case PCI_DEVICE_ID_INTEL_NTB_SS_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_SS_HSX:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_HSX:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_HSX:
+ ndev->hwerr_flags |= NTB_HWERR_SDOORBELL_LOCKUP;
+ break;
+ }
+ switch (pdev->device) {
/* There is a hardware errata related to accessing any register in
* SB01BASE in the presence of bidirectional traffic crossing the NTB.
*/
- ndev->hwerr_flags |= NTB_HWERR_SB01BASE_LOCKUP;
+ case PCI_DEVICE_ID_INTEL_NTB_SS_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_SS_HSX:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_HSX:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_HSX:
+ ndev->hwerr_flags |= NTB_HWERR_SB01BASE_LOCKUP;
+ break;
+ }
+ switch (pdev->device) {
/* HW Errata on bit 14 of b2bdoorbell register. Writes will not be
* mirrored to the remote system. Shrink the number of bits by one,
* since bit 14 is the last bit.
*/
- ndev->hwerr_flags |= NTB_HWERR_B2BDOORBELL_BIT14;
+ case PCI_DEVICE_ID_INTEL_NTB_SS_JSF:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_JSF:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_JSF:
+ case PCI_DEVICE_ID_INTEL_NTB_SS_SNB:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_SNB:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_SNB:
+ case PCI_DEVICE_ID_INTEL_NTB_SS_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_IVT:
+ case PCI_DEVICE_ID_INTEL_NTB_SS_HSX:
+ case PCI_DEVICE_ID_INTEL_NTB_PS_HSX:
+ case PCI_DEVICE_ID_INTEL_NTB_B2B_HSX:
+ ndev->hwerr_flags |= NTB_HWERR_B2BDOORBELL_BIT14;
+ break;
+ }
ndev->reg = &snb_reg;
- pdev = ndev_pdev(ndev);
-
rc = pci_read_config_byte(pdev, SNB_PPD_OFFSET, &ppd);
if (rc)
return -EIO;
--
2.4.0.rc0.43.gcf8a8c6
next prev parent reply other threads:[~2015-06-09 14:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 9:44 [PATCH v3 00/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 01/18] NTB: Move files in preparation for NTB abstraction Allen Hubbe
2015-06-09 16:16 ` Bjorn Helgaas
2015-06-09 16:42 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 02/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 16:23 ` Bjorn Helgaas
2015-06-09 16:43 ` Hubbe, Allen
2015-06-09 16:53 ` Bjorn Helgaas
2015-06-09 17:32 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 03/18] NTB: Read peer info from local SPAD in transport Allen Hubbe
2015-06-09 16:24 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 04/18] NTB: Enable link for Intel root port mode in probe Allen Hubbe
2015-06-09 9:44 ` Allen Hubbe [this message]
2015-06-09 9:44 ` [PATCH v3 06/18] NTB: Differentiate transport link down messages Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 07/18] NTB: Do not advance transport RX on link down Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 08/18] NTB: Reset transport QP link stats on down Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 09/18] NTB: Add parameters for Intel SNB B2B addresses Allen Hubbe
2015-06-09 16:42 ` Bjorn Helgaas
2015-06-09 16:59 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 10/18] NTB: Add ping pong test client Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 11/18] NTB: Add tool " Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 12/18] NTB: Rate limit ntb_qp_link_work Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 13/18] NTB: Use NUMA memory and DMA chan in transport Allen Hubbe
2015-06-09 16:43 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 14/18] NTB: Use NUMA memory in Intel driver Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 15/18] NTB: Improve performance with write combining Allen Hubbe
2015-06-09 16:46 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 16/18] NTB: Default to CPU memcpy for performance Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 17/18] NTB: Rename intel hw to proper platform names Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Allen Hubbe
2015-06-09 16:04 ` Bjorn Helgaas
2015-06-09 16:45 ` Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530e415992e4c4e23831bfbdf7b25cca1811378d.1433838377.git.Allen.Hubbe@emc.com \
--to=allen.hubbe@emc.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®