From: Allen Hubbe <Allen.Hubbe@emc.com>
To: linux-ntb@googlegroups.com
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>
Subject: [PATCH v3 07/18] NTB: Do not advance transport RX on link down
Date: Tue, 9 Jun 2015 05:44:34 -0400 [thread overview]
Message-ID: <83b2f5bc6a46053d04b3bcd90eaadf1cf9da55d4.1433838377.git.Allen.Hubbe@emc.com> (raw)
In-Reply-To: <cover.1433838377.git.Allen.Hubbe@emc.com>
In-Reply-To: <cover.1433838377.git.Allen.Hubbe@emc.com>
On link down, don't advance RX index to the next entry. The next entry
should never be valid after receiving the link down flag.
Signed-off-by: Allen Hubbe <Allen.Hubbe@emc.com>
---
drivers/ntb/ntb_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index 8d9b59f7fa07..0f86b60a0c0e 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -1212,8 +1212,7 @@ static int ntb_process_rxc(struct ntb_transport_qp *qp)
dev_dbg(&qp->ndev->pdev->dev, "link down flag set\n");
ntb_qp_link_down(qp);
hdr->flags = 0;
- iowrite32(qp->rx_index, &qp->rx_info->entry);
- return 0;
+ return -EAGAIN;
}
if (hdr->ver != (u32)qp->rx_pkts) {
--
2.4.0.rc0.43.gcf8a8c6
next prev parent reply other threads:[~2015-06-09 14:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 9:44 [PATCH v3 00/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 01/18] NTB: Move files in preparation for NTB abstraction Allen Hubbe
2015-06-09 16:16 ` Bjorn Helgaas
2015-06-09 16:42 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 02/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 16:23 ` Bjorn Helgaas
2015-06-09 16:43 ` Hubbe, Allen
2015-06-09 16:53 ` Bjorn Helgaas
2015-06-09 17:32 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 03/18] NTB: Read peer info from local SPAD in transport Allen Hubbe
2015-06-09 16:24 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 04/18] NTB: Enable link for Intel root port mode in probe Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 05/18] NTB: Check the device ID to set errata flags Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 06/18] NTB: Differentiate transport link down messages Allen Hubbe
2015-06-09 9:44 ` Allen Hubbe [this message]
2015-06-09 9:44 ` [PATCH v3 08/18] NTB: Reset transport QP link stats on down Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 09/18] NTB: Add parameters for Intel SNB B2B addresses Allen Hubbe
2015-06-09 16:42 ` Bjorn Helgaas
2015-06-09 16:59 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 10/18] NTB: Add ping pong test client Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 11/18] NTB: Add tool " Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 12/18] NTB: Rate limit ntb_qp_link_work Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 13/18] NTB: Use NUMA memory and DMA chan in transport Allen Hubbe
2015-06-09 16:43 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 14/18] NTB: Use NUMA memory in Intel driver Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 15/18] NTB: Improve performance with write combining Allen Hubbe
2015-06-09 16:46 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 16/18] NTB: Default to CPU memcpy for performance Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 17/18] NTB: Rename intel hw to proper platform names Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Allen Hubbe
2015-06-09 16:04 ` Bjorn Helgaas
2015-06-09 16:45 ` Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b2f5bc6a46053d04b3bcd90eaadf1cf9da55d4.1433838377.git.Allen.Hubbe@emc.com \
--to=allen.hubbe@emc.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®