mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andy Lutomirski <luto@amacapital.net>,
	Stefani Seibold <stefani@seibold.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	John Stultz <john.stultz@linaro.org>,
	Pavel Emelyanov <xemul@parallels.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	andriy.shevchenko@linux.intel.com,
	Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com
Subject: Re: Final: Add 32 bit VDSO time function support
Date: Sat, 01 Mar 2014 14:56:01 -0800	[thread overview]
Message-ID: <53126581.1090407@zytor.com> (raw)
In-Reply-To: <CALCETrUH1tZcu0upkTV0gsXtpnf-BAY4vmWKnN19=ZXsbqWT8A@mail.gmail.com>

On 02/28/2014 06:00 PM, Andy Lutomirski wrote:
> 
> This leads to a potentially interesting question: is rdtsc_barrier()
> actually necessary on UP?  IIRC the point is that, if an
> rdtsc_barrier(); rdtsc in one thread is "before" (in the sense of
> being synchronized by some memory operation) an rdtsc_barrier(); rdtsc
> in another thread, then the first rdtsc needs to return an earlier or
> equal time to the second one.
> 
> I assume that no UP CPU is silly enough to execute two rdtsc
> instructions out of order relative to each other in the absence of
> barriers.  So this is a nonissue on UP.
> 
> On the other hand, suppose that some code does:
> 
> volatile long x = *(something that's not in cache)
> clock_gettime
> 
> I can imagine a modern CPU speculating far enough ahead that the rdtsc
> happens *before* the cache miss.  This won't cause visible
> non-monotonicity as far as I can see, but it might annoy people who
> try to benchmark their code.
> 
> Note: actually making this change might be a bit tricky.  I don't know
> if the alternatives code is smart enough.
> 

Let's put it this way... this is at best a third-order optimization...
let's not worry about it right now.

	-hpa



  reply	other threads:[~2014-03-01 22:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 19:34 Stefani Seibold
2014-02-26 20:10 ` Andy Lutomirski
2014-02-26 20:45 ` Greg KH
2014-02-26 20:54   ` Andy Lutomirski
2014-02-27  0:55     ` Andy Lutomirski
2014-02-27  1:02       ` [PATCH 0/2] Improvements/fixes to 32-bit vdso timing Andy Lutomirski
2014-02-27  1:02         ` [PATCH 1/2] x86: Mark __vdso entries as asmlinkage Andy Lutomirski
2014-02-27  3:25           ` H. Peter Anvin
2014-02-27  3:39           ` Andi Kleen
2014-02-27  5:06             ` H. Peter Anvin
2014-02-27  5:19               ` Andy Lutomirski
2014-02-27  5:22                 ` H. Peter Anvin
2014-02-27 20:11                   ` Andy Lutomirski
2014-02-27 23:12                     ` H. Peter Anvin
2014-02-27  5:07             ` H. Peter Anvin
2014-02-27  1:02         ` [PATCH 2/2] x86: Inline the CLOCK_MONOTONIC vdso code Andy Lutomirski
2014-02-28  0:18       ` [PATCH v2 0/4] vDSO fixes, on top of tip/x86/vdso Andy Lutomirski
2014-02-28  0:18         ` [PATCH v2 1/4] x86: Use the default ABI for the 32-bit vDSO Andy Lutomirski
2014-02-28  7:28           ` Stefani Seibold
2014-02-28 15:06             ` H. Peter Anvin
2014-02-28 20:19               ` Andy Lutomirski
2014-03-01 13:43                 ` Stefani Seibold
2014-02-28  0:18         ` [PATCH v2 2/4] x86: Inline the CLOCK_MONOTONIC vdso code Andy Lutomirski
2014-02-28  0:18         ` [PATCH v2 3/4] x86: Patch alternatives in the 32-bit vDSO Andy Lutomirski
2014-02-28  7:22           ` Stefani Seibold
2014-03-01 14:04           ` Stefani Seibold
2014-02-28  0:18         ` [PATCH v2 4/4] x86: Zero-pad the VVAR page Andy Lutomirski
2014-02-28  7:33         ` [PATCH v2 0/4] vDSO fixes, on top of tip/x86/vdso Stefani Seibold
2014-02-28 20:15           ` Andy Lutomirski
2014-03-01 14:02             ` Stefani Seibold
2014-02-28  7:22       ` Final: Add 32 bit VDSO time function support Stefani Seibold
2014-03-01  2:00         ` Andy Lutomirski
2014-03-01 22:56           ` H. Peter Anvin [this message]
2014-03-02  8:01             ` Stefani Seibold
2014-02-27  5:07     ` H. Peter Anvin
2014-02-27 12:14     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53126581.1090407@zytor.com \
    --to=hpa@zytor.com \
    --cc=Andreas.Brief@rohde-schwarz.com \
    --cc=Martin.Runge@rohde-schwarz.com \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gorcunov@openvz.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=stefani@seibold.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome