From: Stephen Warren <swarren@wwwdotorg.org>
To: Wei Ni <wni@nvidia.com>, Guenter Roeck <linux@roeck-us.net>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008
Date: Tue, 04 Mar 2014 19:58:26 -0700 [thread overview]
Message-ID: <531692D2.6040204@wwwdotorg.org> (raw)
In-Reply-To: <53168C5B.6070003@nvidia.com>
On 03/04/2014 07:30 PM, Wei Ni wrote:
> On 03/05/2014 06:23 AM, Guenter Roeck wrote:
>> On Tue, Mar 04, 2014 at 03:06:48PM -0700, Stephen Warren wrote:
>>> On 03/04/2014 04:31 AM, Wei Ni wrote:
>>>> Add dt node to describe the thermal zone for the nct1008.
>>>>
>>>> Change-Id: I0256836e52d73ec282574e4fd91df52958936e35
>>>
>>> ???????
>>>
>> I think this is for one of those open-source sites out there
>> which count open source contributions. Not Ohloh, but similar.
>> You have to specify that Change-Id to have it associate your
>> name with the patch.
>
> It's so sorry, I'm working for chromiumos, this change-id is generated
> by gerrit, I should remove it.
>
>>
>> Guenter
>>
>>>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
>>>
>>>> + thermal-zones {
>>>> + nct1008-local {
>>>> + polling-delay-passive = <2000>; /* milliseconds */
>>>
>>> Nothing can possible make use of this node, since there's no compatible
>>> value or anything else like that to bind a driver to it.
>
> We have special Tskin driver that estimator skin temperature based on
> nct1008 local and remote sensors.
Where? Anything that gets added to the upstream kernel DT files must be
supported by a driver and binding in the upstream kernel.
next prev parent reply other threads:[~2014-03-05 2:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 11:31 [PATCH v2 0/3] expose lm90 to thermal fw Wei Ni
2014-03-04 11:31 ` [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes Wei Ni
2014-03-04 11:31 ` [PATCH v2 2/3] hwmon: lm90: expose to thermal fw via DT nodes Wei Ni
2014-03-04 11:31 ` [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008 Wei Ni
2014-03-04 22:06 ` Stephen Warren
2014-03-04 22:23 ` Guenter Roeck
2014-03-05 2:30 ` Wei Ni
2014-03-05 2:58 ` Stephen Warren [this message]
2014-03-05 3:07 ` Wei Ni
2014-03-05 3:14 ` Stephen Warren
2014-03-05 4:26 ` Wei Ni
2014-03-05 4:30 ` Wei Ni
2014-03-06 17:59 ` Stephen Warren
2014-03-07 3:45 ` Wei Ni
2014-03-07 4:23 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531692D2.6040204@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome