From: Stephen Warren <swarren@wwwdotorg.org>
To: Wei Ni <wni@nvidia.com>, khali@linux-fr.org, linux@roeck-us.net
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008
Date: Thu, 06 Mar 2014 10:59:44 -0700 [thread overview]
Message-ID: <5318B790.8090808@wwwdotorg.org> (raw)
In-Reply-To: <1393932664-13319-4-git-send-email-wni@nvidia.com>
On 03/04/2014 04:31 AM, Wei Ni wrote:
> Add dt node to describe the thermal zone for the nct1008.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + thermal-zones {
> + nct1008-local {
> + polling-delay-passive = <2000>; /* milliseconds */
> + polling-delay = <0>; /* milliseconds */
A delay of 0 implies that software continually polls this zone, thus
consuming an entire CPU. Is this really what you want?
> +
> + thermal-sensors = <&nct1008 0>;
> + };
This zone (and the other) is missing the required (per the binding
documentation) trips and cooling-maps sub-nodes.
I've also sent a query in response to the thermal-zones binding so see
whether or not it can be fixed so that software doesn't bind against the
node name, but rather against a compatible property like almost
everything else. Let's see what the response is there before reposting
this patch.
next prev parent reply other threads:[~2014-03-06 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 11:31 [PATCH v2 0/3] expose lm90 to thermal fw Wei Ni
2014-03-04 11:31 ` [PATCH v2 1/3] hwmon: (lm90) split set&show temp as common codes Wei Ni
2014-03-04 11:31 ` [PATCH v2 2/3] hwmon: lm90: expose to thermal fw via DT nodes Wei Ni
2014-03-04 11:31 ` [PATCH v2 3/3] ARM: tegra: dalmore: add thermal zones for nct1008 Wei Ni
2014-03-04 22:06 ` Stephen Warren
2014-03-04 22:23 ` Guenter Roeck
2014-03-05 2:30 ` Wei Ni
2014-03-05 2:58 ` Stephen Warren
2014-03-05 3:07 ` Wei Ni
2014-03-05 3:14 ` Stephen Warren
2014-03-05 4:26 ` Wei Ni
2014-03-05 4:30 ` Wei Ni
2014-03-06 17:59 ` Stephen Warren [this message]
2014-03-07 3:45 ` Wei Ni
2014-03-07 4:23 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318B790.8090808@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome