From: Ian Abbott <abbotti@mev.co.uk>
To: Fred Akers <knivey@botops.net>,
gregkh@linuxfoundation.org, hsweeten@visionengravers.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names
Date: Tue, 11 Mar 2014 14:31:07 +0000 [thread overview]
Message-ID: <531F1E2B.3040300@mev.co.uk> (raw)
In-Reply-To: <1394350009-23464-1-git-send-email-knivey@botops.net>
On 2014-03-09 07:26, Fred Akers wrote:
> This patch fixes a few function names that are very long and are
> not in the correct naming style
>
> Signed-off-by: Fred Akers <knivey@botops.net>
> ---
> .../comedi/drivers/addi-data/hwdrv_apci1564.c | 62 ++++++++++------------
> drivers/staging/comedi/drivers/addi_apci_1564.c | 16 +++---
> 2 files changed, 36 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> index a31e115..cb426e7 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> @@ -116,7 +116,7 @@ static unsigned int ui_InterruptData, ui_Type;
>
> /*
> +----------------------------------------------------------------------------+
> -| Function Name : int i_APCI1564_ConfigDigitalInput |
> +| Function Name : int i_apci1564_di_config |
It would be nice to get rid of the silly i_, v_ prefixes as well!
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2014-03-11 14:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 7:26 Fred Akers
2014-03-11 14:31 ` Ian Abbott [this message]
2014-03-11 15:01 ` Fred Akers
2014-03-11 17:32 ` [PATCH v2] Staging: comedi: addi-data: " Fred Akers
2014-03-11 17:42 ` Hartley Sweeten
2014-03-11 17:49 ` Joe Perches
2014-03-11 17:53 ` Hartley Sweeten
2014-03-11 22:19 ` [PATCH v3 1/2] " Fred Akers
2014-03-12 0:07 ` Hartley Sweeten
2014-03-12 1:06 ` Hartley Sweeten
2014-03-12 1:25 ` Fred Akers
2014-03-12 17:48 ` Ian Abbott
2014-03-11 22:19 ` [PATCH v3 2/2] Staging: Comedi: addi-data: Clean up function comments Fred Akers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F1E2B.3040300@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=knivey@botops.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome