mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Hartley Sweeten <HartleyS@visionengravers.com>,
	Fred Akers <knivey@botops.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names
Date: Wed, 12 Mar 2014 17:48:52 +0000	[thread overview]
Message-ID: <53209E04.1010509@mev.co.uk> (raw)
In-Reply-To: <DC148C5AA1CEBA4E87973D432B1C2D8825DADED5@P3PWEX4MB008.ex4.secureserver.net>

On 2014-03-12 01:06, Hartley Sweeten wrote:
> On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote:
>> This patch fixes a few function names that are very long and are
>> not in the correct naming style
>>
>> Signed-off-by: Fred Akers <knivey@botops.net>
>
> Fred,
>
> I pulled Greg's staging tree to see if your patches apply.
>
> Patch 1/2 is ok but patch 2/2 does not apply:
>
> Applying: Staging: Comedi: addi-data: Clean up function comments
> error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c:1
> error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c: patch does not apply
> error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c:1
> error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c: patch does not apply
> error: patch failed: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:1
> error: drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: patch does not apply
> Patch failed at 0001 Staging: Comedi: addi-data: Clean up function comments
>
> Maybe Greg will have better luck.
>
> Regards,
> Hartley
>

FWIW, I managed to apply them, but mainly because our internal MS 
Exchange server (which often messes up patches) is down, so I'm having 
to deliver the mail to a "proper" mail server. :)

(Also, the patches in the driverdev-devel archive don't apply as-is, 
partly because it replaces '@' with ' at ', and partly because it 
replaces the ezsett character in 'Dieselstraße' with a question mark '?'.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


  parent reply	other threads:[~2014-03-12 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09  7:26 [PATCH] Staging: comedi: apci_1564: " Fred Akers
2014-03-11 14:31 ` Ian Abbott
2014-03-11 15:01   ` Fred Akers
2014-03-11 17:32 ` [PATCH v2] Staging: comedi: addi-data: " Fred Akers
2014-03-11 17:42   ` Hartley Sweeten
2014-03-11 17:49     ` Joe Perches
2014-03-11 17:53       ` Hartley Sweeten
2014-03-11 22:19 ` [PATCH v3 1/2] " Fred Akers
2014-03-12  0:07   ` Hartley Sweeten
2014-03-12  1:06   ` Hartley Sweeten
2014-03-12  1:25     ` Fred Akers
2014-03-12 17:48     ` Ian Abbott [this message]
2014-03-11 22:19 ` [PATCH v3 2/2] Staging: Comedi: addi-data: Clean up function comments Fred Akers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53209E04.1010509@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=HartleyS@visionengravers.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knivey@botops.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome