From: "H. Peter Anvin" <hpa@zytor.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Sarah Newman <srn@prgmr.com>,
David Vrabel <david.vrabel@citrix.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCHv1] x86: don't schedule when handling #NM exception
Date: Mon, 17 Mar 2014 09:55:57 -0700 [thread overview]
Message-ID: <5327291D.60009@zytor.com> (raw)
In-Reply-To: <CAFLBxZZz4Ot0CgWRHNRaM5zVkpf+QdXveFz_m3aVYnKUd9cAdQ@mail.gmail.com>
On 03/17/2014 05:19 AM, George Dunlap wrote:
> On Mon, Mar 17, 2014 at 3:33 AM, H. Peter Anvin <hpa@zytor.com> wrote:
>> No, the right thing is to unf*ck the Xen braindamage and use eagerfpu as a workaround for the legacy hypervisor versions.
>
> The interface wasn't an accident. In the most common case you'll want
> to clear the bit anyway. In PV mode clearing it would require an extra
> trip up into the hypervisor. So this saves one trip up into the
> hypervisor on every context switch which involves an FPU, at the
> expense of not being able to context-switch away when handling the
> trap.
>
> -George
>
The interface was a complete faceplant, because it caused failures.
You're not infinitely unconstrained since you want to play in the same
sandbox as the native architecture, and if you want to have a hope of
avoiding these kinds of failures you really need to avoid making random
"improvements", certainly not without an explicit guest opt-in (the same
we do for the native CPU architecture when adding new features.)
So if this interface wasn't an accident it was active negligence and
incompetence.
-hpa
next prev parent reply other threads:[~2014-03-17 16:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 16:17 David Vrabel
2014-03-10 16:40 ` H. Peter Anvin
2014-03-10 17:15 ` David Vrabel
2014-03-10 17:25 ` H. Peter Anvin
2014-03-17 3:13 ` Sarah Newman
2014-03-17 3:32 ` [PATCH] x86, fpu, xen: Allocate fpu state for xen pv based on PVABI behavior Sarah Newman
2014-03-17 3:33 ` [PATCHv1] x86: don't schedule when handling #NM exception H. Peter Anvin
2014-03-17 3:35 ` [Xen-devel] " Sarah Newman
2014-03-17 3:43 ` H. Peter Anvin
2014-03-17 4:12 ` Sarah Newman
2014-03-17 4:23 ` H. Peter Anvin
2014-03-20 0:00 ` Greg Kroah-Hartman
2014-03-20 2:29 ` H. Peter Anvin
2014-03-17 13:29 ` David Vrabel
2014-03-19 13:21 ` Konrad Rzeszutek Wilk
2014-03-19 15:02 ` H. Peter Anvin
2014-06-23 13:08 ` Konrad Rzeszutek Wilk
2015-03-05 22:08 ` H. Peter Anvin
2015-03-06 11:46 ` [PATCHv4] x86, fpu: remove the logic of non-eager fpu mem allocation at the first usage David Vrabel
2014-03-17 12:19 ` [Xen-devel] [PATCHv1] x86: don't schedule when handling #NM exception George Dunlap
2014-03-17 16:55 ` H. Peter Anvin [this message]
2014-03-17 17:05 ` Jan Beulich
2014-03-17 17:12 ` H. Peter Anvin
2014-03-18 8:14 ` Ingo Molnar
2014-03-17 17:14 ` George Dunlap
2014-03-18 18:17 ` Sarah Newman
2014-03-18 18:27 ` H. Peter Anvin
2014-03-10 16:45 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5327291D.60009@zytor.com \
--to=hpa@zytor.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srn@prgmr.com \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome