From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: delicious quinoa <delicious.quinoa@gmail.com>
Cc: Alan Tull <atull@altera.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dinh Nguyen <dinguyen@altera.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces
Date: Fri, 21 Mar 2014 20:08:15 +0100 [thread overview]
Message-ID: <532C8E1F.8080400@linutronix.de> (raw)
In-Reply-To: <CANk1AXRa4V1ADNaT+T3pYF4zyxni9Y8rmU9UYRoA_7NxW8KWEg@mail.gmail.com>
On 03/21/2014 07:14 PM, delicious quinoa wrote:
>> + gpio@ff708000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "snps,dw-apb-gpio";
>> + reg = <0xff708000 0x1000>;
>> + clocks = <&per_base_clk>;
>> + status = "disabled";
>> +
>> + gpio0: gpio-controller@0 {
>> + compatible = "snps,dw-apb-gpio-port";
>> + gpio-controller;
>> + #gpio-cells = <1>;
>
> #gpio-cells = <2>;
>
> I applied this patch, fixed the gpio-cells, tested on a cyclone5 soc
> devkit, and see that it breaks the interrupts. Did you test this?
No, as I said. in 0/3. Will take a look on that at somepoint next week.
>
> Alan
Sebastian
next prev parent reply other threads:[~2014-03-21 19:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:55 two patches for the synposys gpio controller Sebastian Andrzej Siewior
2014-03-20 19:55 ` [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-03-25 20:37 ` Linus Walleij
2014-03-25 20:37 ` Linus Walleij
2014-03-31 16:22 ` Jamie Iles
2014-03-20 19:55 ` [PATCH 2/3] gpio: dwapb: do not create the irq mapping upfront Sebastian Andrzej Siewior
2014-03-20 20:20 ` delicious quinoa
2014-03-22 12:37 ` Sebastian Andrzej Siewior
2014-03-25 20:43 ` Linus Walleij
2014-03-25 21:17 ` Sebastian Andrzej Siewior
2014-04-08 13:20 ` Linus Walleij
2014-03-20 19:55 ` [PATCH 3/3] ARM: dts: socfpga: add gpio pieces Sebastian Andrzej Siewior
2014-03-21 17:24 ` Gerhard Sittig
2014-03-21 19:10 ` Sebastian Andrzej Siewior
2014-03-21 22:06 ` delicious quinoa
2014-03-21 18:14 ` delicious quinoa
2014-03-21 19:08 ` Sebastian Andrzej Siewior [this message]
2014-03-21 22:15 ` delicious quinoa
2014-03-22 11:28 ` Sebastian Andrzej Siewior
2014-03-26 15:29 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C8E1F.8080400@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=atull@altera.com \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome