* Re: NFSv2 directory cannot longer be exported in 3.14, 3.13 works fine
[not found] <533F2ABF.2030107@gmx.de>
@ 2014-04-05 12:17 ` Toralf Förster
2014-04-05 12:51 ` Jeff Layton
0 siblings, 1 reply; 3+ messages in thread
From: Toralf Förster @ 2014-04-05 12:17 UTC (permalink / raw)
To: Linux NFS mailing list; +Cc: Linux Kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 04/04/2014 11:57 PM, Toralf Förster wrote:
> At a user mode linux image (32 bit Gentoo Linux) the recent kernel gives this error while trying to mount a NFSv2 directory:
> mount.nfs: mount point /mnt/nfsv2 is not a directory
>
A bisect points to :
6e14b46b91fee8a049b0940333ce13a820beaaa5 is the first bad commit
commit 6e14b46b91fee8a049b0940333ce13a820beaaa5
Author: Albert Fluegel <af@muc.de>
Date: Mon Nov 18 12:18:01 2013 -0500
nfsd: don't return high mode bits
The Linux NFS server replies among other things to a "Check access permission"
the following:
NFS: File type = 2 (Directory)
NFS: Mode = 040755
A netapp server replies here:
NFS: File type = 2 (Directory)
NFS: Mode = 0755
The RFC 1813 i read:
fattr3
struct fattr3 {
ftype3 type;
mode3 mode;
uint32 nlink;
...
For the mode bits only the lowest 9 are defined in the RFC
As far as I can tell, knfsd has always done this, so apparently it's harmless.
Nevertheless, it appears to be wrong.
Note this is already correct in the NFSv4 case, only v2 and v3 need
fixing.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
:040000 040000 a60e55f5a9749db3977e12e8baa08d45fadba225 b982c02ec1069c5d969ccb71197e5569fe93b075 M fs
- --
MfG/Sincerely
Toralf Förster
pgp finger print:1A37 6F99 4A9D 026F 13E2 4DCF C4EA CDDE 0076 E94E
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlM/9FcACgkQxOrN3gB26U5F1AD+JAP4cDM+rT9nk9Q8q681RywT
Ejxq7d0tnVUfWyDFDTgA/1sIUtpv9GSK8SeAJFu7oAhMt4e6eeIdbpMT2qUEQv6q
=Sles
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: NFSv2 directory cannot longer be exported in 3.14, 3.13 works fine
2014-04-05 12:17 ` NFSv2 directory cannot longer be exported in 3.14, 3.13 works fine Toralf Förster
@ 2014-04-05 12:51 ` Jeff Layton
2014-04-05 13:23 ` Toralf Förster
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2014-04-05 12:51 UTC (permalink / raw)
To: Toralf Förster; +Cc: Linux NFS mailing list, Linux Kernel
On Sat, 05 Apr 2014 14:17:27 +0200
Toralf Förster <toralf.foerster@gmx.de> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 04/04/2014 11:57 PM, Toralf Förster wrote:
> > At a user mode linux image (32 bit Gentoo Linux) the recent kernel gives this error while trying to mount a NFSv2 directory:
> > mount.nfs: mount point /mnt/nfsv2 is not a directory
> >
>
> A bisect points to :
>
> 6e14b46b91fee8a049b0940333ce13a820beaaa5 is the first bad commit
> commit 6e14b46b91fee8a049b0940333ce13a820beaaa5
> Author: Albert Fluegel <af@muc.de>
> Date: Mon Nov 18 12:18:01 2013 -0500
>
> nfsd: don't return high mode bits
>
> The Linux NFS server replies among other things to a "Check access permission"
> the following:
>
> NFS: File type = 2 (Directory)
> NFS: Mode = 040755
>
> A netapp server replies here:
> NFS: File type = 2 (Directory)
> NFS: Mode = 0755
>
> The RFC 1813 i read:
> fattr3
>
> struct fattr3 {
> ftype3 type;
> mode3 mode;
> uint32 nlink;
> ...
> For the mode bits only the lowest 9 are defined in the RFC
>
> As far as I can tell, knfsd has always done this, so apparently it's harmless.
> Nevertheless, it appears to be wrong.
>
> Note this is already correct in the NFSv4 case, only v2 and v3 need
> fixing.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>
> :040000 040000 a60e55f5a9749db3977e12e8baa08d45fadba225 b982c02ec1069c5d969ccb71197e5569fe93b075 M fs
>
> - --
> MfG/Sincerely
> Toralf Förster
> pgp finger print:1A37 6F99 4A9D 026F 13E2 4DCF C4EA CDDE 0076 E94E
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iF4EAREIAAYFAlM/9FcACgkQxOrN3gB26U5F1AD+JAP4cDM+rT9nk9Q8q681RywT
> Ejxq7d0tnVUfWyDFDTgA/1sIUtpv9GSK8SeAJFu7oAhMt4e6eeIdbpMT2qUEQv6q
> =Sles
> -----END PGP SIGNATURE-----
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
This was already tracked down earlier this week. Bruce has a patch
queued to fix it in his nfsd-next branch. See this thread from earlier
this week:
Subject: Re: linux-3.14 nfsd regression
--
Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: NFSv2 directory cannot longer be exported in 3.14, 3.13 works fine
2014-04-05 12:51 ` Jeff Layton
@ 2014-04-05 13:23 ` Toralf Förster
0 siblings, 0 replies; 3+ messages in thread
From: Toralf Förster @ 2014-04-05 13:23 UTC (permalink / raw)
To: Jeff Layton; +Cc: Linux NFS mailing list, Linux Kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 04/05/2014 02:51 PM, Jeff Layton wrote:
> This was already tracked down earlier this week. Bruce has a patch
> queued to fix it in his nfsd-next branch. See this thread from
> earlier this week:
>
> Subject: Re: linux-3.14 nfsd regression
yep - fixed the issue here
- --
MfG/Sincerely
Toralf Förster
pgp finger print:1A37 6F99 4A9D 026F 13E2 4DCF C4EA CDDE 0076 E94E
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iF4EAREIAAYFAlNAA7kACgkQxOrN3gB26U5UiwD/X/ONRaFIMGyxHLZd7cwrN4zh
QADbpEhyT+N6KwH6m2wA/j++6yigdEtV7k9pjEWMwlCZUyT8reUbNzZOhxMl10+i
=WGBv
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-05 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <533F2ABF.2030107@gmx.de>
2014-04-05 12:17 ` NFSv2 directory cannot longer be exported in 3.14, 3.13 works fine Toralf Förster
2014-04-05 12:51 ` Jeff Layton
2014-04-05 13:23 ` Toralf Förster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome