* [PATCH 1/2] w1: Use kfree_sensitive instead of memset+kfree
@ 2020-09-09 19:41 Alex Dewar
2020-09-09 20:30 ` Alex Dewar
0 siblings, 1 reply; 2+ messages in thread
From: Alex Dewar @ 2020-09-09 19:41 UTC (permalink / raw)
Cc: Alex Dewar, Evgeniy Polyakov, linux-kernel
Issue identified with Coccinelle.
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
drivers/w1/w1.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index e58c7592008d..4f597b0fd1da 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -71,8 +71,7 @@ static void w1_master_release(struct device *dev)
struct w1_master *md = dev_to_w1_master(dev);
dev_dbg(dev, "%s: Releasing %s.\n", __func__, md->name);
- memset(md, 0, sizeof(struct w1_master) + sizeof(struct w1_bus_master));
- kfree(md);
+ kfree_sensitive(md);
}
static void w1_slave_release(struct device *dev)
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] w1: Use kfree_sensitive instead of memset+kfree
2020-09-09 19:41 [PATCH 1/2] w1: Use kfree_sensitive instead of memset+kfree Alex Dewar
@ 2020-09-09 20:30 ` Alex Dewar
0 siblings, 0 replies; 2+ messages in thread
From: Alex Dewar @ 2020-09-09 20:30 UTC (permalink / raw)
Cc: Evgeniy Polyakov, linux-kernel
On 2020-09-09 20:41, Alex Dewar wrote:
> Issue identified with Coccinelle.
Hmm, on second thoughts, I'm not sure this memory is so sensitive after
all. Should we just remove the call to memset?
>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
> drivers/w1/w1.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index e58c7592008d..4f597b0fd1da 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -71,8 +71,7 @@ static void w1_master_release(struct device *dev)
> struct w1_master *md = dev_to_w1_master(dev);
>
> dev_dbg(dev, "%s: Releasing %s.\n", __func__, md->name);
> - memset(md, 0, sizeof(struct w1_master) + sizeof(struct w1_bus_master));
> - kfree(md);
> + kfree_sensitive(md);
> }
>
> static void w1_slave_release(struct device *dev)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 19:41 [PATCH 1/2] w1: Use kfree_sensitive instead of memset+kfree Alex Dewar
2020-09-09 20:30 ` Alex Dewar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®