From: Michal Simek <michal.simek@xilinx.com>
To: David Binderman <dcb314@hotmail.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"soren.brinkmann@xilinx.com" <soren.brinkmann@xilinx.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c: 2 * pointless local variables ?
Date: Mon, 23 Jan 2017 12:54:11 +0100 [thread overview]
Message-ID: <534e45bf-8a2c-85e4-e18e-0c95a9f97e40@xilinx.com> (raw)
In-Reply-To: <VI1PR08MB1022BE7B66F95FEA77412DDD9C720@VI1PR08MB1022.eurprd08.prod.outlook.com>
On 23.1.2017 12:39, David Binderman wrote:
>
> Hello there,
>
> [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:301]: (style) Variable 'num_writes' is modified but its new value is never used.
> [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:356]: (style) Variable 'read_count' is modified but its new value is never used.
>
> Suggest either use these local variables in some way or delete them.
>
I have sent patch which removes them.
Thanks,
Michal
parent reply other threads:[~2017-01-23 11:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <VI1PR08MB1022BE7B66F95FEA77412DDD9C720@VI1PR08MB1022.eurprd08.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534e45bf-8a2c-85e4-e18e-0c95a9f97e40@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=dcb314@hotmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®