* Re: [PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c
[not found] <1398323941-2596-1-git-send-email-chase.southwood@yahoo.com>
@ 2014-04-24 9:22 ` Ian Abbott
2014-04-24 18:43 ` Hartley Sweeten
1 sibling, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2014-04-24 9:22 UTC (permalink / raw)
To: Chase Southwood, gregkh; +Cc: hsweeten, devel, linux-kernel
On 2014-04-24 08:19, Chase Southwood wrote:
> Using the addi-data "common" code in addi_apci_1564 introduces a lot of
> bloat. By separating this driver off from addi_common.c, a lot of the
> common code can be stripped out. This patch copies the code over from
> addi_common.c, and removes the #include of the file. The auto_attach
> function from the common code replaces the one that was previously in this
> driver, though renamed to that it stays within the namespace associated
> with this driver, and the detach function has been renamed for this reason
> as well.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> ---
> Compile tested only.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c
[not found] <1398323941-2596-1-git-send-email-chase.southwood@yahoo.com>
2014-04-24 9:22 ` [PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c Ian Abbott
@ 2014-04-24 18:43 ` Hartley Sweeten
1 sibling, 0 replies; 2+ messages in thread
From: Hartley Sweeten @ 2014-04-24 18:43 UTC (permalink / raw)
To: Chase Southwood, gregkh; +Cc: abbotti, devel, linux-kernel
On Thursday, April 24, 2014 12:19 AM, Chase Southwood wrote:
> Using the addi-data "common" code in addi_apci_1564 introduces a lot of
> bloat. By separating this driver off from addi_common.c, a lot of the
> common code can be stripped out. This patch copies the code over from
> addi_common.c, and removes the #include of the file. The auto_attach
> function from the common code replaces the one that was previously in this
> driver, though renamed to that it stays within the namespace associated
> with this driver, and the detach function has been renamed for this reason
> as well.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> ---
> Compile tested only.
Looks good.
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-24 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1398323941-2596-1-git-send-email-chase.southwood@yahoo.com>
2014-04-24 9:22 ` [PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c Ian Abbott
2014-04-24 18:43 ` Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®