* [PATCH 1/2] staging: rtl8192e: A word in printk is split into 2 lines @ 2014-04-24 16:48 Masanari Iida 2014-04-24 16:48 ` [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e Masanari Iida 0 siblings, 1 reply; 5+ messages in thread From: Masanari Iida @ 2014-04-24 16:48 UTC (permalink / raw) To: Larry.Finger, gregkh, linux-wireless; +Cc: linux-kernel, Masanari Iida A word in printk is split into two lines. Change it into one line. Signed-off-by: Masanari Iida <standby24x7@gmail.com> --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index adc6cc7..4d5b0de 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -230,8 +230,8 @@ static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst, if (skb) softmac_mgmt_xmit(skb, ieee); else - RTLLIB_DEBUG(RTLLIB_DL_ERR, "alloc skb error in func" - "tion %s()\n", __func__); + RTLLIB_DEBUG(RTLLIB_DL_ERR, "alloc skb error in function" + " %s()\n", __func__); return ; } -- 2.0.0.rc0.26.g779792a ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e 2014-04-24 16:48 [PATCH 1/2] staging: rtl8192e: A word in printk is split into 2 lines Masanari Iida @ 2014-04-24 16:48 ` Masanari Iida 2014-04-24 21:49 ` James Cameron 0 siblings, 1 reply; 5+ messages in thread From: Masanari Iida @ 2014-04-24 16:48 UTC (permalink / raw) To: Larry.Finger, gregkh, linux-wireless; +Cc: linux-kernel, Masanari Iida Fix spelling typo in comments within rtl8192e. Signed-off-by: Masanari Iida <standby24x7@gmail.com> --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c index 5f10e40..79d86b9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c @@ -373,7 +373,7 @@ u32 cmpk_message_handle_rx(struct net_device *dev, default: RT_TRACE(COMP_CMDPKT, "---->cmpk_message_handle_rx():" - "unknow CMD Element\n"); + "unknown CMD Element\n"); return 1; } diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c index 5d6d304..b4bfafe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -1555,7 +1555,7 @@ static bool SetRFPowerState8190(struct net_device *dev, default: bResult = false; - RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknow state" + RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknown state" " to set: 0x%X!!!\n", eRFPowerState); break; } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c index 498995d..59494f5 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = { }; /* - * the following rule need to be follwing, + * the following rule need to be following, * Odd : get (world access), * even : set (root access) * */ diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c index 29608e5..52b2977 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -79,7 +79,7 @@ static void RxPktPendingTimeout(unsigned long data) if (index > REORDER_WIN_SIZE) { RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():" - " Rx Reorer struct buffer full!!\n"); + " Rx Reorder struct buffer full!!\n"); spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags); return; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index 6c8a8e1..7413816 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -712,7 +712,7 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee, if (index > REORDER_WIN_SIZE) { RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():" - " Rx Reorer struct buffer full!!\n"); + " Rx Reorder struct buffer full!!\n"); spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags); return; diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 4bf72bc..d65cba4 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -543,7 +543,7 @@ void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh) goto out; /* scan completed */ } while (!ieee->active_channel_map[ch]); - /* this fuction can be called in two situations + /* this function can be called in two situations * 1- We have switched to ad-hoc mode and we are * performing a complete syncro scan before conclude * there are no interesting cell and to create a -- 2.0.0.rc0.26.g779792a ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e 2014-04-24 16:48 ` [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e Masanari Iida @ 2014-04-24 21:49 ` James Cameron 2014-04-26 14:35 ` [PATCH/V2] " Masanari Iida 0 siblings, 1 reply; 5+ messages in thread From: James Cameron @ 2014-04-24 21:49 UTC (permalink / raw) To: Masanari Iida; +Cc: Larry.Finger, gregkh, linux-wireless, linux-kernel On Fri, Apr 25, 2014 at 01:48:41AM +0900, Masanari Iida wrote: > Fix spelling typo in comments within rtl8192e. > > Signed-off-by: Masanari Iida <standby24x7@gmail.com> > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- > drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- > drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- > drivers/staging/rtl8192e/rtllib_rx.c | 2 +- > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > ... > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > index 498995d..59494f5 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = { > }; > > /* > - * the following rule need to be follwing, > + * the following rule need to be following, > * Odd : get (world access), > * even : set (root access) > * */ The change is good, and a better change might be "s/rule/rules" and "s/following/followed". On the other hand, no other driver mentions this implementation detail of IW_IS_SET in declaration of iw_priv_args, so perhaps the whole comment block should be removed. Either way; Reviewed-by: James Cameron <quozl@laptop.org> p.s. nice to see you again. -- James Cameron http://quozl.linux.org.au/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH/V2] staging: rtl8192e: Fix typo in rtl8192e 2014-04-24 21:49 ` James Cameron @ 2014-04-26 14:35 ` Masanari Iida 2014-04-26 17:09 ` Randy Dunlap 0 siblings, 1 reply; 5+ messages in thread From: Masanari Iida @ 2014-04-26 14:35 UTC (permalink / raw) To: Larry.Finger, gregkh, linux-wireless Cc: linux-kernel, devel, quozl, Masanari Iida Fix spelling typo in comments within rtl8192e. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Reviewed-by: James Cameron <quozl@laptop.org> --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c index 5f10e40..79d86b9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c @@ -373,7 +373,7 @@ u32 cmpk_message_handle_rx(struct net_device *dev, default: RT_TRACE(COMP_CMDPKT, "---->cmpk_message_handle_rx():" - "unknow CMD Element\n"); + "unknown CMD Element\n"); return 1; } diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c index 5d6d304..b4bfafe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -1555,7 +1555,7 @@ static bool SetRFPowerState8190(struct net_device *dev, default: bResult = false; - RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknow state" + RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknown state" " to set: 0x%X!!!\n", eRFPowerState); break; } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c index 498995d..091dfe7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = { }; /* - * the following rule need to be follwing, + * the followed rules need to be following, * Odd : get (world access), * even : set (root access) * */ diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c index 29608e5..52b2977 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -79,7 +79,7 @@ static void RxPktPendingTimeout(unsigned long data) if (index > REORDER_WIN_SIZE) { RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():" - " Rx Reorer struct buffer full!!\n"); + " Rx Reorder struct buffer full!!\n"); spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags); return; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index 6c8a8e1..7413816 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -712,7 +712,7 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee, if (index > REORDER_WIN_SIZE) { RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():" - " Rx Reorer struct buffer full!!\n"); + " Rx Reorder struct buffer full!!\n"); spin_unlock_irqrestore(&(ieee->reorder_spinlock), flags); return; diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 4bf72bc..d65cba4 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -543,7 +543,7 @@ void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh) goto out; /* scan completed */ } while (!ieee->active_channel_map[ch]); - /* this fuction can be called in two situations + /* this function can be called in two situations * 1- We have switched to ad-hoc mode and we are * performing a complete syncro scan before conclude * there are no interesting cell and to create a -- 2.0.0.rc1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH/V2] staging: rtl8192e: Fix typo in rtl8192e 2014-04-26 14:35 ` [PATCH/V2] " Masanari Iida @ 2014-04-26 17:09 ` Randy Dunlap 0 siblings, 0 replies; 5+ messages in thread From: Randy Dunlap @ 2014-04-26 17:09 UTC (permalink / raw) To: Masanari Iida, Larry.Finger, gregkh, linux-wireless Cc: linux-kernel, devel, quozl On 04/26/14 07:35, Masanari Iida wrote: > Fix spelling typo in comments within rtl8192e. > > Signed-off-by: Masanari Iida <standby24x7@gmail.com> > Reviewed-by: James Cameron <quozl@laptop.org> > > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- > drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- > drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- > drivers/staging/rtl8192e/rtllib_rx.c | 2 +- > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c > index 5f10e40..79d86b9 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c > @@ -373,7 +373,7 @@ u32 cmpk_message_handle_rx(struct net_device *dev, > default: > > RT_TRACE(COMP_CMDPKT, "---->cmpk_message_handle_rx():" > - "unknow CMD Element\n"); > + "unknown CMD Element\n"); > return 1; > } > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > index 5d6d304..b4bfafe 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > @@ -1555,7 +1555,7 @@ static bool SetRFPowerState8190(struct net_device *dev, > > default: > bResult = false; > - RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknow state" > + RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknown state" > " to set: 0x%X!!!\n", eRFPowerState); > break; > } > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > index 498995d..091dfe7 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = { > }; > > /* > - * the following rule need to be follwing, > + * the followed rules need to be following, the following rules need to be followed: or these listed rules need to be followed: or this list of rules should be used: etc. > * Odd : get (world access), > * even : set (root access) > * */ > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c > index 29608e5..52b2977 100644 > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c > @@ -79,7 +79,7 @@ static void RxPktPendingTimeout(unsigned long data) > > if (index > REORDER_WIN_SIZE) { > RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():" > - " Rx Reorer struct buffer full!!\n"); > + " Rx Reorder struct buffer full!!\n"); > spin_unlock_irqrestore(&(ieee->reorder_spinlock), > flags); > return; > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c > index 6c8a8e1..7413816 100644 > --- a/drivers/staging/rtl8192e/rtllib_rx.c > +++ b/drivers/staging/rtl8192e/rtllib_rx.c > @@ -712,7 +712,7 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee, > > if (index > REORDER_WIN_SIZE) { > RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():" > - " Rx Reorer struct buffer full!!\n"); > + " Rx Reorder struct buffer full!!\n"); > spin_unlock_irqrestore(&(ieee->reorder_spinlock), > flags); > return; > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c > index 4bf72bc..d65cba4 100644 > --- a/drivers/staging/rtl8192e/rtllib_softmac.c > +++ b/drivers/staging/rtl8192e/rtllib_softmac.c > @@ -543,7 +543,7 @@ void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh) > goto out; /* scan completed */ > } while (!ieee->active_channel_map[ch]); > > - /* this fuction can be called in two situations > + /* this function can be called in two situations > * 1- We have switched to ad-hoc mode and we are > * performing a complete syncro scan before conclude > * there are no interesting cell and to create a > -- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-04-26 17:09 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-04-24 16:48 [PATCH 1/2] staging: rtl8192e: A word in printk is split into 2 lines Masanari Iida 2014-04-24 16:48 ` [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e Masanari Iida 2014-04-24 21:49 ` James Cameron 2014-04-26 14:35 ` [PATCH/V2] " Masanari Iida 2014-04-26 17:09 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome