From: micky <micky_ching@realsil.com.cn>
To: <devel@linuxdriverproject.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>
Cc: <rogerable@realtek.com>, <wei_wang@realsil.com.cn>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: rts5208: fix static checker warnings
Date: Wed, 30 Apr 2014 09:19:58 +0800 [thread overview]
Message-ID: <53604FBE.2050701@realsil.com.cn> (raw)
In-Reply-To: <1396432732-26514-1-git-send-email-micky_ching@realsil.com.cn>
Hi Dan,
I have send this patch to fix the static checker warning, but not
applied yet.
Best Regards.
micky.
On 04/02/2014 05:58 PM, micky_ching@realsil.com.cn wrote:
> From: Micky Ching <micky_ching@realsil.com.cn>
>
> The patch fa590c222fba: "staging: rts5208: add support for rts5208
> and rts5288" from Nov 12, 2013, leads to the following static checker
> warning:
> drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
> warn: add curly braces?
> This warning is produced because incorrect code indent.
>
> Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
> ---
> drivers/staging/rts5208/rtsx_chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index 6426807..7907e93 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -104,7 +104,7 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
> if (chip->ic_version >= IC_VER_C)
> reg |= DELINK_INT_EN;
> #ifdef SUPPORT_OCP
> - reg |= OC_INT_EN;
> + reg |= OC_INT_EN;
> #endif
> if (!chip->adma_mode)
> reg |= DATA_DONE_INT_EN;
prev parent reply other threads:[~2014-04-30 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 9:58 micky_ching
2014-04-30 1:19 ` micky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53604FBE.2050701@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®