* [PATCH] staging: rts5208: fix static checker warnings
@ 2014-04-02 9:58 micky_ching
2014-04-30 1:19 ` micky
0 siblings, 1 reply; 2+ messages in thread
From: micky_ching @ 2014-04-02 9:58 UTC (permalink / raw)
To: devel, linux-kernel, gregkh; +Cc: rogerable, wei_wang, Micky Ching
From: Micky Ching <micky_ching@realsil.com.cn>
The patch fa590c222fba: "staging: rts5208: add support for rts5208
and rts5288" from Nov 12, 2013, leads to the following static checker
warning:
drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
warn: add curly braces?
This warning is produced because incorrect code indent.
Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
index 6426807..7907e93 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -104,7 +104,7 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
if (chip->ic_version >= IC_VER_C)
reg |= DELINK_INT_EN;
#ifdef SUPPORT_OCP
- reg |= OC_INT_EN;
+ reg |= OC_INT_EN;
#endif
if (!chip->adma_mode)
reg |= DATA_DONE_INT_EN;
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rts5208: fix static checker warnings
2014-04-02 9:58 [PATCH] staging: rts5208: fix static checker warnings micky_ching
@ 2014-04-30 1:19 ` micky
0 siblings, 0 replies; 2+ messages in thread
From: micky @ 2014-04-30 1:19 UTC (permalink / raw)
To: devel, linux-kernel, gregkh; +Cc: rogerable, wei_wang, Dan Carpenter
Hi Dan,
I have send this patch to fix the static checker warning, but not
applied yet.
Best Regards.
micky.
On 04/02/2014 05:58 PM, micky_ching@realsil.com.cn wrote:
> From: Micky Ching <micky_ching@realsil.com.cn>
>
> The patch fa590c222fba: "staging: rts5208: add support for rts5208
> and rts5288" from Nov 12, 2013, leads to the following static checker
> warning:
> drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
> warn: add curly braces?
> This warning is produced because incorrect code indent.
>
> Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
> ---
> drivers/staging/rts5208/rtsx_chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index 6426807..7907e93 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -104,7 +104,7 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
> if (chip->ic_version >= IC_VER_C)
> reg |= DELINK_INT_EN;
> #ifdef SUPPORT_OCP
> - reg |= OC_INT_EN;
> + reg |= OC_INT_EN;
> #endif
> if (!chip->adma_mode)
> reg |= DATA_DONE_INT_EN;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-30 1:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-02 9:58 [PATCH] staging: rts5208: fix static checker warnings micky_ching
2014-04-30 1:19 ` micky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®