* Re: [PATCH v1] net-sysfs: expose permanent hardware address in sysfs
2014-05-06 3:34 ` [PATCH v1] net-sysfs: expose permanent hardware address in sysfs David Decotigny
@ 2014-05-07 5:24 ` Florian Fainelli
2014-05-07 20:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2014-05-07 5:24 UTC (permalink / raw)
To: David Decotigny, David S. Miller, netdev, linux-kernel
Cc: Greg Kroah-Hartman, Eric Dumazet, Eric W. Biederman,
Weilong Chen, Jiri Pirko, Michael Dalton, Al Viro, Tejun Heo
Le 05/05/2014 20:34, David Decotigny a écrit :
> Tested:
> grep . /sys/class/net/*/*addr*
Please also include the relevant sysfs documentation changes in
Documentation/ABI/testing/sysfs-class-net.
Thanks!
>
> Signed-off-by: David Decotigny <decot@googlers.com>
> ---
> net/core/net-sysfs.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index 1cac29e..bf57024 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -127,6 +127,20 @@ static ssize_t address_show(struct device *dev, struct device_attribute *attr,
> }
> static DEVICE_ATTR_RO(address);
>
> +static ssize_t perm_addr_show(struct device *dev, struct device_attribute *attr,
> + char *buf)
> +{
> + struct net_device *net = to_net_dev(dev);
> + ssize_t ret = -EINVAL;
> +
> + read_lock(&dev_base_lock);
> + if (dev_isalive(net))
> + ret = sysfs_format_mac(buf, net->perm_addr, net->addr_len);
> + read_unlock(&dev_base_lock);
> + return ret;
> +}
> +static DEVICE_ATTR_RO(perm_addr);
> +
> static ssize_t broadcast_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> @@ -391,6 +405,7 @@ static struct attribute *net_class_attrs[] = {
> &dev_attr_addr_len.attr,
> &dev_attr_link_mode.attr,
> &dev_attr_address.attr,
> + &dev_attr_perm_addr.attr,
> &dev_attr_broadcast.attr,
> &dev_attr_speed.attr,
> &dev_attr_duplex.attr,
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] net-sysfs: expose permanent hardware address in sysfs
2014-05-06 3:34 ` [PATCH v1] net-sysfs: expose permanent hardware address in sysfs David Decotigny
2014-05-07 5:24 ` Florian Fainelli
@ 2014-05-07 20:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-07 20:16 UTC (permalink / raw)
To: decot
Cc: netdev, linux-kernel, gregkh, edumazet, ebiederm, chenweilong,
jiri, mwdalton, viro, tj
From: David Decotigny <decot@googlers.com>
Date: Mon, 5 May 2014 20:34:00 -0700
> Tested:
> grep . /sys/class/net/*/*addr*
>
> Signed-off-by: David Decotigny <decot@googlers.com>
ETHTOOL_GPERMADDR exists already, please use that instead, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread