From: Ryan Wanner <ryan.wanner@microchip.com>
To: Claudiu Beznea <claudiu.beznea@tuxon.dev>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] ARM: dts: microchip: sama7d65: Add clock name property
Date: Wed, 11 Jun 2025 12:51:22 -0700 [thread overview]
Message-ID: <5373558c-d075-4a35-a941-623e385cdc22@microchip.com> (raw)
In-Reply-To: <dc0c2777-ed5b-4729-8ae3-6563d8996e2e@tuxon.dev>
On 6/7/25 04:57, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi, Ryan,
>
> On 23.05.2025 23:24, Ryan.Wanner@microchip.com wrote:
>> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>>
>> Add clock-output-names to the xtal nodes, so the driver can correctly
>> register the main and slow xtal.
>>
>> This fixes the issue of the SoC clock driver not being able to find
>> the main xtal and slow xtal correctly causing a bad clock tree.
>>
>> Fixes: 261dcfad1b59 ("ARM: dts: microchip: add sama7d65 SoC DT")
>
> Can you please prepare a similar fix for sam9x7. It is also affected by
> this, right?
The driver looks for the xtal differently in the sam9x75 than in the
SAMA7 clock drivers, so it is not immediately affected. But I will add a
sam9x7 in the v2 of the patch since in the future it will be needed.
Thank you,
Ryan
>
> Thank you,
> Claudiu
>
>> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
>> ---
>> arch/arm/boot/dts/microchip/sama7d65.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
>> index b6710ccd4c36..7b1dd28a2cfa 100644
>> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
>> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
>> @@ -38,11 +38,13 @@ cpu0: cpu@0 {
>> clocks {
>> main_xtal: clock-mainxtal {
>> compatible = "fixed-clock";
>> + clock-output-names = "main_xtal";
>> #clock-cells = <0>;
>> };
>>
>> slow_xtal: clock-slowxtal {
>> compatible = "fixed-clock";
>> + clock-output-names = "slow_xtal";
>> #clock-cells = <0>;
>> };
>> };
>
prev parent reply other threads:[~2025-06-11 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 20:24 [PATCH v4 0/2] AT91 SAMA7 SoC Clock Adjustments Ryan.Wanner
2025-05-23 20:24 ` [PATCH v4 1/2] ARM: dts: microchip: sama7g5: Adjust clock xtal phandle Ryan.Wanner
2025-06-07 11:53 ` Claudiu Beznea
2025-05-23 20:24 ` [PATCH v4 2/2] ARM: dts: microchip: sama7d65: Add clock name property Ryan.Wanner
2025-06-07 11:57 ` Claudiu Beznea
2025-06-11 19:51 ` Ryan Wanner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5373558c-d075-4a35-a941-623e385cdc22@microchip.com \
--to=ryan.wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®