* [PATCH] staging: removing warnings reported by checkpatch tool on cb_pcimdas.c
@ 2014-05-10 16:24 Raghavendra Ganiga
2014-05-19 16:56 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Raghavendra Ganiga @ 2014-05-10 16:24 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, devel; +Cc: ravi23ganiga, linux-kernel
This is a patch to remove warnings reported
by checkpatch tool on cb_pcimdas.c file
Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
---
drivers/staging/comedi/drivers/cb_pcimdas.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b/drivers/staging/comedi/drivers/cb_pcimdas.c
index d3141c8..50e522e 100644
--- a/drivers/staging/comedi/drivers/cb_pcimdas.c
+++ b/drivers/staging/comedi/drivers/cb_pcimdas.c
@@ -31,7 +31,8 @@ Configuration Options:
Developed from cb_pcidas and skel by Richard Bytheway (mocelet@sucs.org).
Only supports DIO, AO and simple AI in it's present form.
-No interrupts, multi channel or FIFO AI, although the card looks like it could support this.
+No interrupts, multi channel or FIFO AI,
+although the card looks like it could support this.
See http://www.mccdaq.com/PDFs/Manuals/pcim-das1602-16.pdf for more details.
*/
@@ -128,8 +129,12 @@ static int cb_pcimdas_ai_rinsn(struct comedi_device *dev,
d = d & 0xfd;
outb(d, devpriv->BADR3 + 5);
}
- outb(0x01, devpriv->BADR3 + 6); /* set bursting off, conversions on */
- outb(0x00, devpriv->BADR3 + 7); /* set range to 10V. UP/BP is controlled by a switch on the board */
+
+ /* set bursting off, conversions on */
+ outb(0x01, devpriv->BADR3 + 6);
+
+ /* set range to 10V. UP/BP is controlled by a switch on the board */
+ outb(0x00, devpriv->BADR3 + 7);
/*
* write channel limits to multiplexer, set Low (bits 0-3) and
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: removing warnings reported by checkpatch tool on cb_pcimdas.c
2014-05-10 16:24 [PATCH] staging: removing warnings reported by checkpatch tool on cb_pcimdas.c Raghavendra Ganiga
@ 2014-05-19 16:56 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2014-05-19 16:56 UTC (permalink / raw)
To: Raghavendra Ganiga, Ian Abbott, hsweeten, gregkh, devel; +Cc: linux-kernel
On 2014-05-10 17:24, Raghavendra Ganiga wrote:
> This is a patch to remove warnings reported
> by checkpatch tool on cb_pcimdas.c file
>
> Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com>
> ---
> drivers/staging/comedi/drivers/cb_pcimdas.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-19 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-10 16:24 [PATCH] staging: removing warnings reported by checkpatch tool on cb_pcimdas.c Raghavendra Ganiga
2014-05-19 16:56 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome