From: "H. Peter Anvin" <hpa@zytor.com>
To: Andy Lutomirski <luto@kernel.org>, x86@kernel.org
Cc: Mario Limonciello <mario_limonciello@dell.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Borislav Petkov <bp@alien8.de>, Matt Fleming <mfleming@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] x86/efi: Allocate a trampoline if needed in efi_free_boot_services()
Date: Sun, 31 Jul 2016 22:07:07 -0700 [thread overview]
Message-ID: <5389d894-64c0-5f5f-6ed6-e08077f1dc8e@zytor.com> (raw)
In-Reply-To: <f2cc98f71f7e2b2d0b525b94265c297bb51a3564.1469573005.git.luto@kernel.org>
On 07/26/16 15:55, Andy Lutomirski wrote:
> + /*
> + * Nasty quirk: if all sub-1MB memory is used for boot
> + * services, we can get here without having allocated the
> + * real mode trampoline. It's too late to hand boot services
> + * memory back to the memblock allocator, so instead
> + * try to reclaim a single page if needed.
> + *
This comment makes no sense. Nowhere is there a dependency on a single
page, and this refers to allocation, not reclaim...
-hpa
next prev parent reply other threads:[~2016-08-01 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 22:55 [PATCH 4.8? 0/4] Allow the trampoline to use EFI boot services RAM Andy Lutomirski
2016-07-26 22:55 ` [PATCH 1/4] x86/boot: Synchronize trampoline_cr4_features and mmu_cr4_features directly Andy Lutomirski
2016-07-26 22:55 ` [PATCH 2/4] x86/boot: Defer setup_real_mode() to early_initcall time Andy Lutomirski
2016-07-26 22:55 ` [PATCH 3/4] x86/boot: Rework reserve_real_mode() to allow multiple tries Andy Lutomirski
2016-07-26 22:55 ` [PATCH 4/4] x86/efi: Allocate a trampoline if needed in efi_free_boot_services() Andy Lutomirski
2016-08-01 5:07 ` H. Peter Anvin [this message]
2016-08-02 18:21 ` Andy Lutomirski
2016-07-31 21:38 ` [PATCH 4.8? 0/4] Allow the trampoline to use EFI boot services RAM Matt Fleming
2016-08-04 9:26 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5389d894-64c0-5f5f-6ed6-e08077f1dc8e@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mfleming@suse.de \
--cc=mjg59@srcf.ucam.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®