Re: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy

Re: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy

[Seth Jennings]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1331 bytes --]


On Jun 7, 2014 6:08 AM, Fabian Frederick <fabf@skynet.be> wrote:
>
> zswap_entry_cache_destroy is only called by __init init_zswap 
>
> This patch also fixes function name 
> zswap_entry_cache_ s/destory/destroy

Thanks for the  improvement ☺

Acked-by <sjennings@variantweb.net>

>
> Cc: Seth Jennings <sjennings@variantweb.net> 
> Cc: linux-mm@kvack.org 
> Cc: Andrew Morton <akpm@linux-foundation.org> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be> 
> --- 
> mm/zswap.c | 4 ++-- 
> 1 file changed, 2 insertions(+), 2 deletions(-) 
>
> diff --git a/mm/zswap.c b/mm/zswap.c 
> index aeaef0f..ab7fa0f 100644 
> --- a/mm/zswap.c 
> +++ b/mm/zswap.c 
> @@ -207,7 +207,7 @@ static int zswap_entry_cache_create(void) 
> return zswap_entry_cache == NULL; 
> } 
>
> -static void zswap_entry_cache_destory(void) 
> +static void __init zswap_entry_cache_destroy(void) 
> { 
> kmem_cache_destroy(zswap_entry_cache); 
> } 
> @@ -926,7 +926,7 @@ static int __init init_zswap(void) 
> pcpufail: 
> zswap_comp_exit(); 
> compfail: 
> - zswap_entry_cache_destory(); 
> + zswap_entry_cache_destroy(); 
> cachefail: 
> zbud_destroy_pool(zswap_pool); 
> error: 
> -- 
> 1.9.1 
>
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

[PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy

[Fabian Frederick]

zswap_entry_cache_destroy is only called by __init init_zswap

This patch also fixes function name
zswap_entry_cache_ s/destory/destroy

Cc: Seth Jennings <sjennings@variantweb.net>
Cc: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 mm/zswap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index aeaef0f..ab7fa0f 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -207,7 +207,7 @@ static int zswap_entry_cache_create(void)
 	return zswap_entry_cache == NULL;
 }
 
-static void zswap_entry_cache_destory(void)
+static void __init zswap_entry_cache_destroy(void)
 {
 	kmem_cache_destroy(zswap_entry_cache);
 }
@@ -926,7 +926,7 @@ static int __init init_zswap(void)
 pcpufail:
 	zswap_comp_exit();
 compfail:
-	zswap_entry_cache_destory();
+	zswap_entry_cache_destroy();
 cachefail:
 	zbud_destroy_pool(zswap_pool);
 error:
-- 
1.9.1