HID: hid-sensor-hub: fix sleeping function called from invalid context

HID: hid-sensor-hub: fix sleeping function called from invalid context

[Alexander Holler]

Hello,

while rebasing the dozens (currently around 60) of refused, ignored or 
similiar bugfixes and patches I need to use a Linux kernel, I've noticed 
that Jiri Kosinas patch here

https://lkml.org/lkml/2013/8/9/214

doesn't apply anymore.

Looking why, I've seen that a similiar patch from Srinivas Pandruvada 
named like the topic ended up in the kernel.

Looking at the differences, I wonder if not all spin_lock() calls in 
hid-sensor-hub.c should be changed into spin_lock_irqsave() like the 
patch from Jiri Kosina did.

Regards,

Alexander Holler

(sorry for the duplicate message, I've forgotten to add the 
wanna-be-reviewer-school named lkml to the recipients)

Re: HID: hid-sensor-hub: fix sleeping function called from invalid context

[Jiri Kosina]

On Tue, 10 Jun 2014, Alexander Holler wrote:

> Hello,
> 
> while rebasing the dozens (currently around 60) of refused, ignored or
> similiar bugfixes and patches I need to use a Linux kernel, I've noticed that
> Jiri Kosinas patch here
> 
> https://lkml.org/lkml/2013/8/9/214
> 
> doesn't apply anymore.
> 
> Looking why, I've seen that a similiar patch from Srinivas Pandruvada named
> like the topic ended up in the kernel.

Hi Alexander,

thanks for drawing this one from the boulevard of forgotten patches.

I am actually not aware of any patch by Srinivas that would conflict with 
the one I've written -- could you please elaborate where you believe the 
conflict is?

> Looking at the differences, I wonder if not all spin_lock() calls in 
> hid-sensor-hub.c should be changed into spin_lock_irqsave() like the 
> patch from Jiri Kosina did.

Could you please give me your Tested-by:? I'll then be happily queuing the 
fix. Thanks.

> (sorry for the duplicate message, I've forgotten to add the
> wanna-be-reviewer-school named lkml to the recipients)

You want to make it to LWN quotes of the week, don't you? :)

-- 
Jiri Kosina
SUSE Labs

Re: HID: hid-sensor-hub: fix sleeping function called from invalid context

[Srinivas Pandruvada]

On 06/09/2014 03:40 PM, Jiri Kosina wrote:
> On Tue, 10 Jun 2014, Alexander Holler wrote:
>
>> Hello,
>>
>> while rebasing the dozens (currently around 60) of refused, ignored or
>> similiar bugfixes and patches I need to use a Linux kernel, I've noticed that
>> Jiri Kosinas patch here
>>
>> https://lkml.org/lkml/2013/8/9/214
>>
>> doesn't apply anymore.
>>
>> Looking why, I've seen that a similiar patch from Srinivas Pandruvada named
>> like the topic ended up in the kernel.
>
> Hi Alexander,
>
> thanks for drawing this one from the boulevard of forgotten patches.
>
> I am actually not aware of any patch by Srinivas that would conflict with
> the one I've written -- could you please elaborate where you believe the
> conflict is?
>
>> Looking at the differences, I wonder if not all spin_lock() calls in
>> hid-sensor-hub.c should be changed into spin_lock_irqsave() like the
>> patch from Jiri Kosina did.
>

There is a patch submitted by "reyad.attiyat@gmail.com"
[PATCH] HID: hid-sensor-hub: Fix lockdep warning for dynamic callback locks.

Already doing this, what you suggested?

+Reyad


Thanks,
Srinivas


> Could you please give me your Tested-by:? I'll then be happily queuing the
> fix. Thanks.
>
>> (sorry for the duplicate message, I've forgotten to add the
>> wanna-be-reviewer-school named lkml to the recipients)
>
> You want to make it to LWN quotes of the week, don't you? :)
>

Re: HID: hid-sensor-hub: fix sleeping function called from invalid context

[Jiri Kosina]

On Mon, 9 Jun 2014, Srinivas Pandruvada wrote:

> > > while rebasing the dozens (currently around 60) of refused, ignored 
> > > or similiar bugfixes and patches I need to use a Linux kernel, I've 
> > > noticed that Jiri Kosinas patch here
> > > 
> > > https://lkml.org/lkml/2013/8/9/214
> > > 
> > > doesn't apply anymore.
> > > 
> > > Looking why, I've seen that a similiar patch from Srinivas Pandruvada
> > > named
> > > like the topic ended up in the kernel.
> > 
> > Hi Alexander,
> > 
> > thanks for drawing this one from the boulevard of forgotten patches.
> > 
> > I am actually not aware of any patch by Srinivas that would conflict with
> > the one I've written -- could you please elaborate where you believe the
> > conflict is?
> > 
> > > Looking at the differences, I wonder if not all spin_lock() calls in
> > > hid-sensor-hub.c should be changed into spin_lock_irqsave() like the
> > > patch from Jiri Kosina did.
> > 
> 
> There is a patch submitted by "reyad.attiyat@gmail.com"
> [PATCH] HID: hid-sensor-hub: Fix lockdep warning for dynamic callback locks.
> 
> Already doing this, what you suggested?

I don't see this in my mailbox at all .. so where was this submitted to, 
and who merged it to which tree?

-- 
Jiri Kosina
SUSE Labs

Re: HID: hid-sensor-hub: fix sleeping function called from invalid context

[Alexander Holler]

Am 10.06.2014 00:40, schrieb Jiri Kosina:
> On Tue, 10 Jun 2014, Alexander Holler wrote:
> 
>> Hello,
>>
>> while rebasing the dozens (currently around 60) of refused, ignored or
>> similiar bugfixes and patches I need to use a Linux kernel, I've noticed that
>> Jiri Kosinas patch here
>>
>> https://lkml.org/lkml/2013/8/9/214
>>
>> doesn't apply anymore.
>>
>> Looking why, I've seen that a similiar patch from Srinivas Pandruvada named
>> like the topic ended up in the kernel.
> 
> Hi Alexander,
> 
> thanks for drawing this one from the boulevard of forgotten patches.
> 
> I am actually not aware of any patch by Srinivas that would conflict with 
> the one I've written -- could you please elaborate where you believe the 
> conflict is?

I actually don't rebase from main-version to main-version (that doesn't
really work), but I'm using format-patch and git am. It's a bit more
strict when that's ok. I haven't looked in deep which changes in 3.15 do
conflict with the patch based on 3.14, but it't can't be that much.

>> Looking at the differences, I wonder if not all spin_lock() calls in 
>> hid-sensor-hub.c should be changed into spin_lock_irqsave() like the 
>> patch from Jiri Kosina did.
> 
> Could you please give me your Tested-by:? I'll then be happily queuing the 
> fix. Thanks.

Sure, but I already did that in the reply to your patch.

>> (sorry for the duplicate message, I've forgotten to add the
>> wanna-be-reviewer-school named lkml to the recipients)
> 
> You want to make it to LWN quotes of the week, don't you? :)

No, I'm just too often the object of their first steps and that's why I
won't post any patches on lkml anymore. It might be fun for them to do
reviews on patches from innocent people, but those victims usually don't
share their view. Maybe I will choose full disclosure or similiar I ever
will have an important patch poor Linux users should really have a need for.

Regards,

Alexander Holler

Re: HID: hid-sensor-hub: fix sleeping function called from invalid context

[Jiri Kosina]

On Tue, 10 Jun 2014, Alexander Holler wrote:

> >> Looking at the differences, I wonder if not all spin_lock() calls in 
> >> hid-sensor-hub.c should be changed into spin_lock_irqsave() like the 
> >> patch from Jiri Kosina did.
> > 
> > Could you please give me your Tested-by:? I'll then be happily queuing the 
> > fix. Thanks.
> 
> Sure, but I already did that in the reply to your patch.

I probably missed in all the other noise in that thread. I've now pushed 
out the staged patch and will be pushing it to Linus for 3.16 still. 
Thanks,

-- 
Jiri Kosina
SUSE Labs