From: Daniel Wagner <dwagner@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Daniel Wagner <wagi@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
"Michael S. Tsirkin" <mst@redhat.com>,
Aaron Tomlin <atomlin@atomlin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Costa Shulyupin <costa.shul@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Waiman Long <llong@redhat.com>, Ming Lei <ming.lei@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Mel Gorman <mgorman@suse.de>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, megaraidlinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org, storagedev@microchip.com,
virtualization@lists.linux.dev,
GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH v7 01/10] lib/group_cpus: Add group_masks_cpus_evenly()
Date: Wed, 3 Sep 2025 14:36:33 +0200 [thread overview]
Message-ID: <5397286b-bb1f-493b-9d7d-b4168a67efe6@flourine.local> (raw)
In-Reply-To: <db0cbbe2-792c-4263-8be9-14b76eb0f7e6@suse.de>
On Thu, Jul 03, 2025 at 08:18:50AM +0200, Hannes Reinecke wrote:
> > +/**
> > + * group_mask_cpus_evenly - Group all CPUs evenly per NUMA/CPU locality
> > + * @numgrps: number of groups
> > + * @cpu_mask: CPU to consider for the grouping
> > + * @nummasks: number of initialized cpusmasks
> > + *
> > + * Return: cpumask array if successful, NULL otherwise. And each element
> > + * includes CPUs assigned to this group.
> > + *
> > + * Try to put close CPUs from viewpoint of CPU and NUMA locality into
> > + * same group. Allocate present CPUs on these groups evenly.
> > + */
>
> Description could be improved. Point is that you do not do any
> calculation here, you just call __group_cpus_evenly() with
> a different mask.
I updated the documentation, it matches with group_cpus_evenly but with
the constrain mask.
next prev parent reply other threads:[~2025-09-03 12:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 16:33 [PATCH v7 00/10] blk: honor isolcpus configuration Daniel Wagner
2025-07-02 16:33 ` [PATCH v7 01/10] lib/group_cpus: Add group_masks_cpus_evenly() Daniel Wagner
2025-07-03 6:18 ` Hannes Reinecke
2025-09-03 12:36 ` Daniel Wagner [this message]
2025-07-11 8:28 ` John Garry
2025-09-03 12:42 ` Daniel Wagner
2025-07-02 16:33 ` [PATCH v7 02/10] genirq/affinity: Add cpumask to struct irq_affinity Daniel Wagner
2025-07-03 6:19 ` Hannes Reinecke
2025-07-02 16:33 ` [PATCH v7 03/10] blk-mq: add blk_mq_{online|possible}_queue_affinity Daniel Wagner
2025-07-03 6:29 ` Hannes Reinecke
2025-07-02 16:33 ` [PATCH v7 04/10] nvme-pci: use block layer helpers to constrain queue affinity Daniel Wagner
2025-07-03 6:29 ` Hannes Reinecke
2025-07-02 16:33 ` [PATCH v7 05/10] scsi: Use " Daniel Wagner
2025-07-03 6:43 ` Hannes Reinecke
2025-07-04 9:37 ` Daniel Wagner
2025-07-04 10:28 ` Hannes Reinecke
2025-07-04 12:30 ` Daniel Wagner
2025-09-05 7:41 ` Daniel Wagner
2025-07-02 16:33 ` [PATCH v7 06/10] virtio: blk/scsi: use " Daniel Wagner
2025-07-03 6:43 ` Hannes Reinecke
2025-07-02 16:33 ` [PATCH v7 07/10] isolation: Introduce io_queue isolcpus type Daniel Wagner
2025-07-08 1:26 ` Aaron Tomlin
2025-07-02 16:33 ` [PATCH v7 08/10] blk-mq: use hk cpus only when isolcpus=io_queue is enabled Daniel Wagner
2025-07-03 6:58 ` Hannes Reinecke
2025-07-04 9:21 ` Daniel Wagner
2025-07-03 9:01 ` Christoph Hellwig
2025-07-04 9:00 ` Daniel Wagner
2025-07-07 5:42 ` Christoph Hellwig
2025-07-03 14:47 ` kernel test robot
2025-07-02 16:33 ` [PATCH v7 09/10] blk-mq: prevent offlining hk CPUs with associated online isolated CPUs Daniel Wagner
2025-07-03 6:58 ` Hannes Reinecke
2025-07-07 7:44 ` Ming Lei
2025-07-08 1:31 ` Aaron Tomlin
2025-07-08 1:23 ` Aaron Tomlin
2025-07-02 16:34 ` [PATCH v7 10/10] docs: add io_queue flag to isolcpus Daniel Wagner
2025-07-03 6:59 ` Hannes Reinecke
2025-07-08 1:26 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5397286b-bb1f-493b-9d7d-b4168a67efe6@flourine.local \
--to=dwagner@suse.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=atomlin@atomlin.com \
--cc=axboe@kernel.dk \
--cc=costa.shul@redhat.com \
--cc=frederic@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=juri.lelli@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llong@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=mgorman@suse.de \
--cc=ming.lei@redhat.com \
--cc=mst@redhat.com \
--cc=sagi@grimberg.me \
--cc=storagedev@microchip.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux.dev \
--cc=vschneid@redhat.com \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®