From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc
Date: Tue, 22 Feb 2022 10:28:51 +0100 [thread overview]
Message-ID: <53a17fe5-4301-676a-03de-f19055a8a904@kernel.org> (raw)
In-Reply-To: <CY4PR03MB3399F6E389A3014678849ADC9B3B9@CY4PR03MB3399.namprd03.prod.outlook.com>
On 22/02/2022 10:21, Miclaus, Antoniu wrote:
>>
>> Please do not resend without fixing pointed out issues. It just looks
>> you ignore comments.
>>
>> Please fix or respond to previous comments. Please also fix all common
>> issues recently pointed out for all Analog devices - folks from Analog
>> are making the same mistakes. Reviewing the same mistake is a bit a
>> waste of time. Much more appreciated is when team applies one feedback
>> to all its submissions. IOW, do not repeat the same mistake second time.
>>
>>
>> Best regards,
>> Krzysztof
>
> I had a look over the previous comments and I saw that some of them were
> replied by Jonathan already, therefore I fixed only those that were still valid.
> Indeed I missed the "Please put the bindings patch as first in the series",
> my bad on that. Let me know if I missed anything else.
In this patchset you also missed spaces in the subject (after every ':'
character).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-22 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 9:27 [PATCH v4 1/3] iio:amplifiers:ada4250: add support for ADA4250 Antoniu Miclaus
2022-02-21 9:27 ` [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc Antoniu Miclaus
2022-02-21 16:35 ` Krzysztof Kozlowski
2022-02-22 9:21 ` Miclaus, Antoniu
2022-02-22 9:28 ` Krzysztof Kozlowski [this message]
2022-02-21 9:27 ` [PATCH v4 3/3] MAINTAINERS: add maintainer for ADA4250 driver Antoniu Miclaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53a17fe5-4301-676a-03de-f19055a8a904@kernel.org \
--to=krzk@kernel.org \
--cc=Antoniu.Miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®