From: Krzysztof Kozlowski <krzk@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
jic23@kernel.org, robh+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc
Date: Mon, 21 Feb 2022 17:35:42 +0100 [thread overview]
Message-ID: <61e964b4-a406-7721-f3d4-26754c7f865c@kernel.org> (raw)
In-Reply-To: <20220221092740.25511-2-antoniu.miclaus@analog.com>
On 21/02/2022 10:27, Antoniu Miclaus wrote:
> Add device tree bindings for the ADA4250 driver.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v4:
> - add `spi-max-frequency` property
> - use generic node naming
> .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
>
Please do not resend without fixing pointed out issues. It just looks
you ignore comments.
Please fix or respond to previous comments. Please also fix all common
issues recently pointed out for all Analog devices - folks from Analog
are making the same mistakes. Reviewing the same mistake is a bit a
waste of time. Much more appreciated is when team applies one feedback
to all its submissions. IOW, do not repeat the same mistake second time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-21 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 9:27 [PATCH v4 1/3] iio:amplifiers:ada4250: add support for ADA4250 Antoniu Miclaus
2022-02-21 9:27 ` [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc Antoniu Miclaus
2022-02-21 16:35 ` Krzysztof Kozlowski [this message]
2022-02-22 9:21 ` Miclaus, Antoniu
2022-02-22 9:28 ` Krzysztof Kozlowski
2022-02-21 9:27 ` [PATCH v4 3/3] MAINTAINERS: add maintainer for ADA4250 driver Antoniu Miclaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e964b4-a406-7721-f3d4-26754c7f865c@kernel.org \
--to=krzk@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®