From: Lv Zheng <lv.zheng@intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>,
<linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, Bob Moore <robert.moore@intel.com>
Subject: [PATCH 12/13] ACPICA: Debugger: Fix dead lock issue ocurred in single stepping mode
Date: Thu, 15 Oct 2015 10:09:00 +0800 [thread overview]
Message-ID: <53c0c65557f362e9e886bfc2ea262b3e8fab0993.1444874756.git.lv.zheng@intel.com> (raw)
In-Reply-To: <cover.1444874756.git.lv.zheng@intel.com>
ACPICA commit 35273add90da19cd8790fdb5735f52e3c9861684
When single step execution is not ended, executing another control methods
leads to dead locks around interpreter lock/namespace lock/method
serialization lock. So we should only allow one execution from the debugger
at same time. Lv Zheng.
Link: https://github.com/acpica/acpica/commit/35273add
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
---
drivers/acpi/acpica/dbexec.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/acpi/acpica/dbexec.c b/drivers/acpi/acpica/dbexec.c
index 8eef298..9da2daa 100644
--- a/drivers/acpi/acpica/dbexec.c
+++ b/drivers/acpi/acpica/dbexec.c
@@ -370,7 +370,17 @@ acpi_db_execute(char *name, char **args, acpi_object_type * types, u32 flags)
#ifdef ACPI_DEBUG_OUTPUT
u32 previous_allocations;
u32 allocations;
+#endif
+ /*
+ * Allow one execution to be performed by debugger or single step
+ * execution will be dead locked by the interpreter mutexes.
+ */
+ if (acpi_gbl_method_executing) {
+ acpi_os_printf("Only one debugger execution is allowed.\n");
+ return;
+ }
+#ifdef ACPI_DEBUG_OUTPUT
/* Memory allocation tracking */
previous_allocations = acpi_db_get_outstanding_allocations();
--
1.7.10
next prev parent reply other threads:[~2015-10-15 2:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 2:07 [PATCH 00/13] ACPICA: 20150930 Release Lv Zheng
2015-10-15 2:07 ` [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation Lv Zheng
2015-10-15 15:51 ` kbuild test robot
2015-10-15 18:33 ` Moore, Robert
2015-10-16 0:59 ` Zheng, Lv
2015-10-16 13:39 ` Rafael J. Wysocki
2015-10-15 2:07 ` [PATCH 02/13] ACPICA: iASL: Add symbolic operator support for Index() operator Lv Zheng
2015-10-15 2:08 ` [PATCH 03/13] ACPICA: Update exception code for "file not found" error Lv Zheng
2015-10-15 2:08 ` [PATCH 04/13] ACPICA: Debugger: Update mutexes used for multithreaded debugger Lv Zheng
2015-10-15 2:08 ` [PATCH 05/13] ACPICA: Update NFIT table to rename a flags field Lv Zheng
2015-10-15 2:08 ` [PATCH 06/13] ACPICA: Improve typechecking, both compile-time and runtime Lv Zheng
2015-10-15 2:08 ` [PATCH 07/13] ACPICA: iASL: General cleanup of the file suffix #defines Lv Zheng
2015-10-15 2:08 ` [PATCH 08/13] ACPICA: Linuxize: Export debugger files to Linux Lv Zheng
2015-10-15 2:08 ` [PATCH 09/13] ACPICA: Debugger: Fix "quit/exit" command by cleaning up user commands termination logic Lv Zheng
2015-10-15 2:08 ` [PATCH 10/13] ACPICA: Debugger: Fix "terminate" command by cleaning up subsystem shutdown logic Lv Zheng
2015-10-15 2:08 ` [PATCH 11/13] ACPI: Enable build of AML interpreter debugger Lv Zheng
2015-10-15 2:09 ` Lv Zheng [this message]
2015-10-15 2:09 ` [PATCH 13/13] ACPICA: Update version to 20150930 Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53c0c65557f362e9e886bfc2ea262b3e8fab0993.1444874756.git.lv.zheng@intel.com \
--to=lv.zheng@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®