From: Lv Zheng <lv.zheng@intel.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>,
<linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, Bob Moore <robert.moore@intel.com>
Subject: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.
Date: Thu, 15 Oct 2015 10:07:47 +0800 [thread overview]
Message-ID: <aa7d0bcbc2bcc13cf65b7b9a14fa0e6c7329c3b7.1444874756.git.lv.zheng@intel.com> (raw)
In-Reply-To: <cover.1444874756.git.lv.zheng@intel.com>
From: Bob Moore <robert.moore@intel.com>
ACPICA commit eea1f0e561893b6d6417913b2d224082fe3a0a5e
Remove use of ACPI_DEBUGGER and ACPI_DISASSEMBLER where these
defines are used around entire modules.
Note: This type of code also causes problems with IDEs.
Link: https://github.com/acpica/acpica/commit/eea1f0e5
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
drivers/acpi/acpica/acdebug.h | 6 ++++++
drivers/acpi/acpica/rsdump.c | 3 ---
include/acpi/platform/acenv.h | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/acpica/acdebug.h b/drivers/acpi/acpica/acdebug.h
index eb2e926..c928ba4 100644
--- a/drivers/acpi/acpica/acdebug.h
+++ b/drivers/acpi/acpica/acdebug.h
@@ -44,6 +44,12 @@
#ifndef __ACDEBUG_H__
#define __ACDEBUG_H__
+/* The debugger is used in conjunction with the disassembler most of time */
+
+#ifdef ACPI_DISASSEMBLER
+#include "acdisasm.h"
+#endif
+
#define ACPI_DEBUG_BUFFER_SIZE 0x4000 /* 16K buffer for return objects */
struct acpi_db_command_info {
diff --git a/drivers/acpi/acpica/rsdump.c b/drivers/acpi/acpica/rsdump.c
index c428bb3..2a09288 100644
--- a/drivers/acpi/acpica/rsdump.c
+++ b/drivers/acpi/acpica/rsdump.c
@@ -51,7 +51,6 @@ ACPI_MODULE_NAME("rsdump")
/*
* All functions in this module are used by the AML Debugger only
*/
-#if defined(ACPI_DEBUGGER)
/* Local prototypes */
static void acpi_rs_out_string(char *title, char *value);
@@ -565,5 +564,3 @@ static void acpi_rs_dump_word_list(u16 length, u16 *data)
acpi_os_printf("%25s%2.2X : %4.4X\n", "Word", i, data[i]);
}
}
-
-#endif
diff --git a/include/acpi/platform/acenv.h b/include/acpi/platform/acenv.h
index ec00e2b..15ef08c 100644
--- a/include/acpi/platform/acenv.h
+++ b/include/acpi/platform/acenv.h
@@ -142,7 +142,7 @@
#ifdef ACPI_LIBRARY
#define ACPI_USE_LOCAL_CACHE
-#define ACPI_FUTURE_USAGE
+#define ACPI_FULL_DEBUG
#endif
/* Common for all ACPICA applications */
--
1.7.10
next prev parent reply other threads:[~2015-10-15 2:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 2:07 [PATCH 00/13] ACPICA: 20150930 Release Lv Zheng
2015-10-15 2:07 ` Lv Zheng [this message]
2015-10-15 15:51 ` [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation kbuild test robot
2015-10-15 18:33 ` Moore, Robert
2015-10-16 0:59 ` Zheng, Lv
2015-10-16 13:39 ` Rafael J. Wysocki
2015-10-15 2:07 ` [PATCH 02/13] ACPICA: iASL: Add symbolic operator support for Index() operator Lv Zheng
2015-10-15 2:08 ` [PATCH 03/13] ACPICA: Update exception code for "file not found" error Lv Zheng
2015-10-15 2:08 ` [PATCH 04/13] ACPICA: Debugger: Update mutexes used for multithreaded debugger Lv Zheng
2015-10-15 2:08 ` [PATCH 05/13] ACPICA: Update NFIT table to rename a flags field Lv Zheng
2015-10-15 2:08 ` [PATCH 06/13] ACPICA: Improve typechecking, both compile-time and runtime Lv Zheng
2015-10-15 2:08 ` [PATCH 07/13] ACPICA: iASL: General cleanup of the file suffix #defines Lv Zheng
2015-10-15 2:08 ` [PATCH 08/13] ACPICA: Linuxize: Export debugger files to Linux Lv Zheng
2015-10-15 2:08 ` [PATCH 09/13] ACPICA: Debugger: Fix "quit/exit" command by cleaning up user commands termination logic Lv Zheng
2015-10-15 2:08 ` [PATCH 10/13] ACPICA: Debugger: Fix "terminate" command by cleaning up subsystem shutdown logic Lv Zheng
2015-10-15 2:08 ` [PATCH 11/13] ACPI: Enable build of AML interpreter debugger Lv Zheng
2015-10-15 2:09 ` [PATCH 12/13] ACPICA: Debugger: Fix dead lock issue ocurred in single stepping mode Lv Zheng
2015-10-15 2:09 ` [PATCH 13/13] ACPICA: Update version to 20150930 Lv Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa7d0bcbc2bcc13cf65b7b9a14fa0e6c7329c3b7.1444874756.git.lv.zheng@intel.com \
--to=lv.zheng@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®