* [PATCH] mailbox: zynqmp-ipi: Add of_node_put() before goto
@ 2021-10-18 1:34 Wan Jiabing
2021-10-18 7:23 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-10-18 1:34 UTC (permalink / raw)
To: Jassi Brar, Michal Simek, linux-kernel, linux-arm-kernel
Cc: kael_w, Wan Jiabing
Fix following coccicheck warning:
./drivers/mailbox/zynqmp-ipi-mailbox.c:654:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before goto
Early exits from for_each_available_child_of_node should decrement the
node reference counter.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index f44079d62b1a..67d4203fb4f5 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -657,6 +657,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
if (ret) {
dev_err(dev, "failed to probe subdev.\n");
ret = -EINVAL;
+ of_node_put(nc);
goto free_mbox_dev;
}
mbox++;
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: zynqmp-ipi: Add of_node_put() before goto
2021-10-18 1:34 [PATCH] mailbox: zynqmp-ipi: Add of_node_put() before goto Wan Jiabing
@ 2021-10-18 7:23 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2021-10-18 7:23 UTC (permalink / raw)
To: Wan Jiabing, Jassi Brar, Michal Simek, linux-kernel,
linux-arm-kernel, Wendy Liang
Cc: kael_w
+Wendy: Please check.
M
On 10/18/21 03:34, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/mailbox/zynqmp-ipi-mailbox.c:654:1-33: WARNING: Function
> for_each_available_child_of_node should have of_node_put() before goto
>
> Early exits from for_each_available_child_of_node should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index f44079d62b1a..67d4203fb4f5 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -657,6 +657,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
> if (ret) {
> dev_err(dev, "failed to probe subdev.\n");
> ret = -EINVAL;
> + of_node_put(nc);
> goto free_mbox_dev;
> }
> mbox++;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-18 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 1:34 [PATCH] mailbox: zynqmp-ipi: Add of_node_put() before goto Wan Jiabing
2021-10-18 7:23 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®