mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <llong@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>,
	peterz@infradead.org, mingo@kernel.org
Cc: bigeasy@linutronix.de, boqun@kernel.org, will@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] locking/mutex: Rename mutex_init_lockep()
Date: Thu, 19 Feb 2026 08:25:28 -0500	[thread overview]
Message-ID: <53d73c5b-9445-43e1-9969-ec0a3920d47a@redhat.com> (raw)
In-Reply-To: <20260217191512.1180151-2-dave@stgolabs.net>

On 2/17/26 2:15 PM, Davidlohr Bueso wrote:
> Typo, this wants to be _lockdep().
>
> Fixes: 51d7a054521d ("locking/mutex: Redo __mutex_init() to reduce generated code size")
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
>   include/linux/mutex.h  | 4 ++--
>   kernel/locking/mutex.c | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/mutex.h b/include/linux/mutex.h
> index ecaa0440f6ec..8126da959088 100644
> --- a/include/linux/mutex.h
> +++ b/include/linux/mutex.h
> @@ -87,12 +87,12 @@ do {									\
>   	struct mutex mutexname = __MUTEX_INITIALIZER(mutexname)
>   
>   #ifdef CONFIG_DEBUG_LOCK_ALLOC
> -void mutex_init_lockep(struct mutex *lock, const char *name, struct lock_class_key *key);
> +void mutex_init_lockdep(struct mutex *lock, const char *name, struct lock_class_key *key);
>   
>   static inline void __mutex_init(struct mutex *lock, const char *name,
>   				struct lock_class_key *key)
>   {
> -	mutex_init_lockep(lock, name, key);
> +	mutex_init_lockdep(lock, name, key);
>   }
>   #else
>   extern void mutex_init_generic(struct mutex *lock);
> diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
> index 2a1d165b3167..c867f6c15530 100644
> --- a/kernel/locking/mutex.c
> +++ b/kernel/locking/mutex.c
> @@ -171,7 +171,7 @@ static __always_inline bool __mutex_unlock_fast(struct mutex *lock)
>   
>   #else /* !CONFIG_DEBUG_LOCK_ALLOC */
>   
> -void mutex_init_lockep(struct mutex *lock, const char *name, struct lock_class_key *key)
> +void mutex_init_lockdep(struct mutex *lock, const char *name, struct lock_class_key *key)
>   {
>   	__mutex_init_generic(lock);
>   
> @@ -181,7 +181,7 @@ void mutex_init_lockep(struct mutex *lock, const char *name, struct lock_class_k
>   	debug_check_no_locks_freed((void *)lock, sizeof(*lock));
>   	lockdep_init_map_wait(&lock->dep_map, name, key, 0, LD_WAIT_SLEEP);
>   }
> -EXPORT_SYMBOL(mutex_init_lockep);
> +EXPORT_SYMBOL(mutex_init_lockdep);
>   #endif /* !CONFIG_DEBUG_LOCK_ALLOC */
>   
>   static inline void __mutex_set_flag(struct mutex *lock, unsigned long flag)

Yes, this typo can be easy to miss.

Acked-by: Waiman Long <longman@redhat.com>


  parent reply	other threads:[~2026-02-19 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17 19:15 [PATCH -tip 0/3] locking/mutex: Misc fixlets Davidlohr Bueso
2026-02-17 19:15 ` [PATCH 1/3] locking/mutex: Rename mutex_init_lockep() Davidlohr Bueso
2026-02-19  8:32   ` Peter Zijlstra
2026-02-19 13:25   ` Waiman Long [this message]
2026-02-23 10:25   ` [tip: locking/core] " tip-bot2 for Davidlohr Bueso
2026-02-17 19:15 ` [PATCH 2/3] locking/mutex: Fix wrong comment for CONFIG_DEBUG_LOCK_ALLOC Davidlohr Bueso
2026-02-19 13:31   ` Waiman Long
2026-02-23 10:25   ` [tip: locking/core] " tip-bot2 for Davidlohr Bueso
2026-02-17 19:15 ` [PATCH 3/3] locking/mutex: Add killable flavor to guard definitions Davidlohr Bueso
2026-02-23 10:25   ` [tip: locking/core] " tip-bot2 for Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53d73c5b-9445-43e1-9969-ec0a3920d47a@redhat.com \
    --to=llong@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=boqun@kernel.org \
    --cc=dave@stgolabs.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®