From: Nadav Amit <nadav.amit@gmail.com>
To: Gabriel Somlo <gsomlo@gmail.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, "X86 ML" <x86@kernel.org>,
"Joerg Roedel" <joro@8bytes.org>,
"KVM list" <kvm@vger.kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 untested] kvm: better MWAIT emulation for guests
Date: Tue, 21 Mar 2017 17:02:25 -0700 [thread overview]
Message-ID: <540BB5C2-CEAE-47D2-845B-2DDEF3CDC303@gmail.com> (raw)
In-Reply-To: <20170321225116.GJ2231@HEDWIG.INI.CMU.EDU>
> On Mar 21, 2017, at 3:51 PM, Gabriel Somlo <gsomlo@gmail.com> wrote:
>
> And I get the exact same results on the MacBookAir4,2 (which exhibits
> no freezing or extreme sluggishness when running OS X 10.7 smp with
> Michael's KVM MWAIT-in-L1 patch)...
Sorry for my confusion. I didn’t read the entire thread and thought that
the problem is spurious wake-ups.
Since that is not the case, I would just suggest two things that you can
freely ignore:
1. According to the SDM, when an interrupt is delivered, the interrupt
is only delivered on the following instruction, so you may consider
skipping the MWAIT first.
2. Perhaps the CPU changes for some reason GUEST_ACTIVITY_STATE (which
is not according to the SDM).
That is it. No more BS from me.
Nadav
next prev parent reply other threads:[~2017-03-22 0:02 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 21:22 Michael S. Tsirkin
2017-03-15 23:35 ` Gabriel L. Somlo
2017-03-15 23:41 ` Michael S. Tsirkin
2017-03-16 13:24 ` Gabriel L. Somlo
2017-03-16 14:04 ` Michael S. Tsirkin
2017-03-16 14:58 ` Gabriel L. Somlo
2017-03-16 15:23 ` Michael S. Tsirkin
2017-03-16 15:35 ` Radim Krčmář
2017-03-16 16:01 ` Radim Krčmář
2017-03-16 16:47 ` Gabriel L. Somlo
2017-03-16 17:22 ` Radim Krčmář
2017-03-16 17:39 ` Gabriel L. Somlo
2017-03-16 17:27 ` Michael S. Tsirkin
2017-03-16 17:41 ` Gabriel L. Somlo
2017-03-16 18:29 ` Michael S. Tsirkin
2017-03-16 19:24 ` Gabriel L. Somlo
2017-03-16 19:27 ` Michael S. Tsirkin
2017-03-16 20:17 ` Gabriel L. Somlo
2017-03-16 21:14 ` Gabriel L. Somlo
2017-03-17 2:03 ` Michael S. Tsirkin
2017-03-17 13:23 ` Gabriel L. Somlo
2017-03-21 3:22 ` Michael S. Tsirkin
2017-03-21 16:58 ` Radim Krčmář
2017-03-21 17:29 ` Nadav Amit
2017-03-21 19:22 ` Radim Krčmář
2017-03-21 22:51 ` Gabriel Somlo
2017-03-22 0:02 ` Nadav Amit [this message]
2017-03-22 13:35 ` Michael S. Tsirkin
2017-03-22 14:10 ` Gabriel L. Somlo
2017-03-22 14:15 ` Michael S. Tsirkin
2017-03-16 16:16 ` Gabriel L. Somlo
2017-03-16 16:45 ` Michael S. Tsirkin
2017-03-16 16:52 ` Gabriel L. Somlo
2017-03-16 16:54 ` Gabriel L. Somlo
2017-03-16 17:14 ` Michael S. Tsirkin
2017-03-16 17:38 ` Radim Krčmář
2017-03-16 14:08 ` Radim Krčmář
2017-03-16 15:44 ` Gabriel L. Somlo
2017-03-16 15:54 ` Radim Krčmář
2017-03-16 16:26 ` Gabriel L. Somlo
2017-03-21 16:16 ` Joerg Roedel
2017-03-21 18:45 ` Michael S. Tsirkin
2017-03-27 13:34 ` Alexander Graf
2017-03-28 14:28 ` Radim Krčmář
2017-03-28 20:35 ` Jim Mattson
2017-03-29 12:11 ` Radim Krčmář
2017-04-03 10:04 ` Alexander Graf
2017-04-04 12:39 ` Radim Krčmář
2017-04-04 12:51 ` Alexander Graf
2017-04-04 13:13 ` Radim Krčmář
2017-04-04 13:15 ` Alexander Graf
2017-04-04 13:44 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540BB5C2-CEAE-47D2-845B-2DDEF3CDC303@gmail.com \
--to=nadav.amit@gmail.com \
--cc=corbet@lwn.net \
--cc=gsomlo@gmail.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®