From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yassine Oudjana <yassine.oudjana@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: Yassine Oudjana <y.oudjana@protonmail.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: Add bindings for WCD9335 DAIs
Date: Wed, 22 Jun 2022 16:35:04 +0200 [thread overview]
Message-ID: <5421df1e-6e86-27a4-3da7-c15661aee190@linaro.org> (raw)
In-Reply-To: <20220622064758.40543-2-y.oudjana@protonmail.com>
On 22/06/2022 08:47, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Add bindings for the DAIs available in WCD9335 to avoid
> having to use unclear number indices in device trees.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
> MAINTAINERS | 1 +
> include/dt-bindings/sound/qcom,wcd9335.h | 15 +++++++++++++++
> 2 files changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/sound/qcom,wcd9335.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b774f21828f7..2bcc3cc129c5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16366,6 +16366,7 @@ M: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> M: Banajit Goswami <bgoswami@quicinc.com>
> L: alsa-devel@alsa-project.org (moderated for non-subscribers)
> S: Supported
> +F: include/dt-bindings/sound/qcom,wcd9335.h
> F: sound/soc/codecs/lpass-va-macro.c
> F: sound/soc/codecs/lpass-wsa-macro.*
> F: sound/soc/codecs/msm8916-wcd-analog.c
> diff --git a/include/dt-bindings/sound/qcom,wcd9335.h b/include/dt-bindings/sound/qcom,wcd9335.h
> new file mode 100644
> index 000000000000..709d33ca748d
> --- /dev/null
> +++ b/include/dt-bindings/sound/qcom,wcd9335.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +#ifndef __DT_QCOM_WCD9335_H
> +#define __DT_QCOM_WCD9335_H
Header guard should match better path, so:
__DT_SOUND_QCOM_WCD9335_H
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-22 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:47 [PATCH 0/3] " Yassine Oudjana
2022-06-22 6:47 ` [PATCH 1/3] " Yassine Oudjana
2022-06-22 14:35 ` Krzysztof Kozlowski [this message]
2022-06-22 6:47 ` [PATCH 2/3] ASoC: wcd9335: Use DT bindings instead of local DAI definitions Yassine Oudjana
2022-06-22 14:35 ` Krzysztof Kozlowski
2022-06-22 6:47 ` [PATCH 3/3] arm64: dts: qcom: Use WCD9335 DT bindings Yassine Oudjana
2022-06-22 14:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5421df1e-6e86-27a4-3da7-c15661aee190@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®