From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yassine Oudjana <yassine.oudjana@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: Yassine Oudjana <y.oudjana@protonmail.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: Use WCD9335 DT bindings
Date: Wed, 22 Jun 2022 16:36:22 +0200 [thread overview]
Message-ID: <60b0074f-f29b-da1f-d6d0-0085e17e5dcb@linaro.org> (raw)
In-Reply-To: <20220622064758.40543-4-y.oudjana@protonmail.com>
On 22/06/2022 08:47, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Replace DAI indices in codec nodes with definitions from the WCD9335
> DT bindings for devices that use WCD9335.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 5 +++--
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 5 +++--
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts | 5 +++--
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 49afbb1a066a..ff915cd8e5a6 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -13,6 +13,7 @@
> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> #include <dt-bindings/sound/qcom,q6afe.h>
> #include <dt-bindings/sound/qcom,q6asm.h>
> +#include <dt-bindings/sound/qcom,wcd9335.h>
>
> /*
> * GPIO name legend: proper name = the GPIO line is used as GPIO
> @@ -1009,7 +1010,7 @@ platform {
> };
>
> codec {
> - sound-dai = <&wcd9335 6>;
> + sound-dai = <&wcd9335 AIF4_PB>;
> };
> };
>
> @@ -1024,7 +1025,7 @@ platform {
> };
>
> codec {
> - sound-dai = <&wcd9335 1>;
> + sound-dai = <&wcd9335 AIF1_CAP>;
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
> index 22978d06f85b..261f2ea7def0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
> @@ -9,6 +9,7 @@
> #include <dt-bindings/sound/qcom,q6afe.h>
> #include <dt-bindings/sound/qcom,q6asm.h>
> #include <dt-bindings/input/ti-drv260x.h>
> +#include <dt-bindings/sound/qcom,wcd9335.h>
Keep the order, so this goes before input (even though it is not really
alphabetical, but that's life...).
>
> / {
> model = "Xiaomi Mi 5";
> @@ -193,7 +194,7 @@ platform {
> };
>
> codec {
> - sound-dai = <&wcd9335 6>;
> + sound-dai = <&wcd9335 AIF4_PB>;
> };
> };
>
> @@ -208,7 +209,7 @@ platform {
> };
>
> codec {
> - sound-dai = <&wcd9335 1>;
> + sound-dai = <&wcd9335 AIF1_CAP>;
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts
> index 1e2dd6763ad1..c9f935cfb587 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts
> @@ -9,6 +9,7 @@
> #include "pmi8996.dtsi"
> #include <dt-bindings/sound/qcom,q6afe.h>
> #include <dt-bindings/sound/qcom,q6asm.h>
> +#include <dt-bindings/sound/qcom,wcd9335.h>
>
> / {
> model = "Xiaomi Mi Note 2";
> @@ -171,7 +172,7 @@ platform {
> };
>
> codec {
> - sound-dai = <&wcd9335 6>;
> + sound-dai = <&wcd9335 AIF4_PB>;
> };
> };
>
> @@ -186,7 +187,7 @@ platform {
> };
>
> codec {
> - sound-dai = <&wcd9335 1>;
> + sound-dai = <&wcd9335 AIF1_CAP>;
> };
> };
> };
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-22 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:47 [PATCH 0/3] ASoC: dt-bindings: Add bindings for WCD9335 DAIs Yassine Oudjana
2022-06-22 6:47 ` [PATCH 1/3] " Yassine Oudjana
2022-06-22 14:35 ` Krzysztof Kozlowski
2022-06-22 6:47 ` [PATCH 2/3] ASoC: wcd9335: Use DT bindings instead of local DAI definitions Yassine Oudjana
2022-06-22 14:35 ` Krzysztof Kozlowski
2022-06-22 6:47 ` [PATCH 3/3] arm64: dts: qcom: Use WCD9335 DT bindings Yassine Oudjana
2022-06-22 14:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60b0074f-f29b-da1f-d6d0-0085e17e5dcb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®