From: Michael Walle <michael@walle.cc>
To: "Boyapally, Srikanth" <Srikanth.Boyapally@amd.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
tudor.ambarus@linaro.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, "git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g
Date: Wed, 29 Nov 2023 14:05:37 +0100 [thread overview]
Message-ID: <542998283b464d19fa5f354898de79df@walle.cc> (raw)
In-Reply-To: <BN9PR12MB5196EF2D4EFF36F6FCD7BDC19E83A@BN9PR12MB5196.namprd12.prod.outlook.com>
Hi,
>> >> > Add support for issi is25lp02g.
>> >> >
>> >> > Verified on AMD-Xilinx versal platform and executed mtd_debug
>> >> > read/write test.
>> >> >
>> >> > Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>
>> >>
>> >> Based on a datasheet [0] I found online, this flash seems to have
>> >> SFDP.
>> >> And since you do not add any flash specific fixups, it likely does
>> >> not need an entry and would work fine with the generic flash driver.
>> >> Did you try using that? See [1] for more info on contribution
>> >> guidelines.
>> >>
>> >> [0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf
>> >> [1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2-
>> >> tudor.ambarus@linaro.org/
>> >>
>> > I ran mtd_debug read/write tests on this flash, without adding flash
>> > entry, it worked fine for me. Please ignore this patch.
>>
>> Great! Could you please still dump and post your SFDP just for us to
>> have more
>> SFDP of diferent flashes? See [1].
>>
> SFDP dump:
> versal-generic:/home/petalinux# hexdump -C
> /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 00000000 53 46 44 50 06 01 01 ff 00 06 01 10 30 00 00 ff
> |SFDP........0...|
> 00000010 84 00 01 02 80 00 00 ff ff ff ff ff ff ff ff ff
> |................|
> 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> 00000030 e5 20 fb ff ff ff ff 7f 44 eb 08 6b 08 3b 80 bb |.
> ......D..k.;..|
> 00000040 fe ff ff ff ff ff 00 ff ff ff 44 eb 0c 20 0f 52
> |..........D.. .R|
> 00000050 10 d8 00 ff 62 42 a9 00 82 64 02 e2 ec 8d 69 4c
> |....bB...d....iL|
> 00000060 7a 75 7a 75 f7 a2 d5 5c 4a c2 2c ff e8 30 fa a9
> |zuzu...\J.,..0..|
> 00000070 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> 00000080 ff ee ff ff 21 5c dc ff |....!\..|
> 00000088
Thanks!
-michael
prev parent reply other threads:[~2023-11-29 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 5:47 Srikanth Boyapally
2023-11-24 14:47 ` Pratyush Yadav
2023-11-28 6:02 ` Boyapally, Srikanth
2023-11-28 8:36 ` Michael Walle
2023-11-29 12:34 ` Boyapally, Srikanth
2023-11-29 13:05 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542998283b464d19fa5f354898de79df@walle.cc \
--to=michael@walle.cc \
--cc=Srikanth.Boyapally@amd.com \
--cc=git@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®