From: Michael Walle <michael@walle.cc>
To: "Boyapally, Srikanth" <Srikanth.Boyapally@amd.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
tudor.ambarus@linaro.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, "git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g
Date: Tue, 28 Nov 2023 09:36:27 +0100 [thread overview]
Message-ID: <6342ad8a798ef811d37775b7269623a3@walle.cc> (raw)
In-Reply-To: <BN9PR12MB51966705C3E306502ABABA6E9EBCA@BN9PR12MB5196.namprd12.prod.outlook.com>
Hi,
>> > Add support for issi is25lp02g.
>> >
>> > Verified on AMD-Xilinx versal platform and executed mtd_debug
>> > read/write test.
>> >
>> > Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>
>>
>> Based on a datasheet [0] I found online, this flash seems to have
>> SFDP.
>> And since you do not add any flash specific fixups, it likely does not
>> need an entry
>> and would work fine with the generic flash driver. Did you try using
>> that? See [1]
>> for more info on contribution guidelines.
>>
>> [0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf
>> [1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2-
>> tudor.ambarus@linaro.org/
>>
> I ran mtd_debug read/write tests on this flash, without adding flash
> entry, it worked fine for me. Please ignore this patch.
Great! Could you please still dump and post your SFDP just for us to
have more SFDP of diferent flashes? See [1].
-michael
next prev parent reply other threads:[~2023-11-28 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 5:47 Srikanth Boyapally
2023-11-24 14:47 ` Pratyush Yadav
2023-11-28 6:02 ` Boyapally, Srikanth
2023-11-28 8:36 ` Michael Walle [this message]
2023-11-29 12:34 ` Boyapally, Srikanth
2023-11-29 13:05 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6342ad8a798ef811d37775b7269623a3@walle.cc \
--to=michael@walle.cc \
--cc=Srikanth.Boyapally@amd.com \
--cc=git@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®