From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jassi Brar <jaswinder.singh@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh@kernel.org,
ilias.apalodimas@linaro.org, masahisa.kojima@linaro.org
Subject: Re: [PATCH] dt-bindings: arm: socionext: add bindings for the Synquacer platform
Date: Tue, 20 Jun 2023 08:27:17 +0200 [thread overview]
Message-ID: <544a723b-20de-563b-6cc3-5efdeec0aef7@linaro.org> (raw)
In-Reply-To: <CAJe_Zhct9KGVD1t9CTaFhL05oxa9Rawf5g1OVmWOd-NYVNAErA@mail.gmail.com>
On 19/06/2023 21:17, Jassi Brar wrote:
>>>>>> Can we fix them as well?
>>>>>>
>>>>> ??
>>>> What else I can say to such argument?
>>>>
>>> It was not an argument, I agreed to remove it. I just observed that
>>> the nit-pick was arbitrary.
>>> And frankly
>>> "dt-bindings: arm: socionext: add Synquacer" is as misleading as
>>> "dt-bindings: arm: socionext: add bindings for the Synquacer" is improper.
>>
>> "add Synquacer boards"
>> it is both precise and correct. No misleading.
>>
> Ok. I am going to do that. Are you going to enforce this practice for
> all submissions in future?
How many cases can you find that I did not enforce it? That I provided a
review and accepted other subject? It's nothing new...
>
>
>>>>
>>>> Bindings without user (so no DTSI and no driver)? Just few, not countless.
>>>>
>>> I disagree. But I don't have time to write a script to find
>>> compatibles/enums and properties in yaml/txt files that are not in any
>>> dts/dtsi file.
>>> By that logic synquacer's spi/netsec/i2c/exiu bindings and drivers in
>>> kernel are illegit too?
>>
>> Don't know which one you talk about.
>>
> Documentation/devicetree/bindings/
> {
> i2c/socionext,synquacer-i2c.yaml
There is a user. What do you want to prove with this one?
> interrupt-controller/socionext,synquacer-exiu.yaml
> net/socionext,synquacer-netsec.yaml
> spi/socionext,synquacer-spi.yaml
> }
> and corresponding code in drivers/
>
>
>>> The synquacer dts/dtsi are in u-boot upstream. SR testsuite looks up
>>
>> Sure, can you point it? U-Boot upstream is a valid project. Just like
>> many other upstream ones.
>>
> Location of dts/dtsi in u-boot upstream is
> https://elixir.bootlin.com/u-boot/latest/source/arch/arm/dts
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-20 6:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 3:58 jaswinder.singh
2023-06-16 10:15 ` Krzysztof Kozlowski
2023-06-16 13:12 ` Jassi Brar
2023-06-16 10:15 ` Krzysztof Kozlowski
2023-06-16 16:23 ` Jassi Brar
2023-06-16 16:47 ` Krzysztof Kozlowski
2023-06-16 20:06 ` Jassi Brar
2023-06-16 20:34 ` Krzysztof Kozlowski
2023-06-16 23:18 ` Jassi Brar
2023-06-17 7:18 ` Krzysztof Kozlowski
2023-06-19 19:17 ` Jassi Brar
2023-06-20 6:27 ` Krzysztof Kozlowski [this message]
2023-06-20 16:50 ` Rob Herring
2023-06-20 17:08 ` Jassi Brar
2023-06-20 17:07 ` [PATCHv2] dt-bindings: arm: socionext: add Synquacer platforms jaswinder.singh
2023-06-20 17:16 ` Krzysztof Kozlowski
2023-06-20 17:24 ` Jassi Brar
2023-06-20 17:54 ` Krzysztof Kozlowski
2023-06-20 18:21 ` Jassi Brar
2023-06-21 15:36 ` [PATCHv3] " jaswinder.singh
2023-06-22 2:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544a723b-20de-563b-6cc3-5efdeec0aef7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahisa.kojima@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®