mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jassi Brar <jaswinder.singh@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org, robh@kernel.org,
	ilias.apalodimas@linaro.org, masahisa.kojima@linaro.org
Subject: Re: [PATCHv2] dt-bindings: arm: socionext: add Synquacer platforms
Date: Tue, 20 Jun 2023 19:54:39 +0200	[thread overview]
Message-ID: <dce591cb-ee6c-15cf-e5aa-6b2dc739984a@linaro.org> (raw)
In-Reply-To: <CAJe_Zhc7-LU0X6epmOoo3nE0j+e_zROsA+J0s0vSUA-sTJ6jBw@mail.gmail.com>

On 20/06/2023 19:24, Jassi Brar wrote:
>>> +properties:
>>> +  $nodename:
>>> +    const: '/'
>>> +  compatible:
>>> +    oneOf:
>>> +      - items:
>>> +          - enum:
>>> +              - socionext,developer-box
>>> +              - socionext,synquacer
>>> +          - const: socionext,sc2a11b
>>
>> That's quite different change.
>>
> So it is not carrying your ack.
> 
>> What is synquacer in this case? You claim
>> now it is a board, but based on previous discussions and U-Boot source
>> it does not look like such.
>>
> I never made that claim. I said Kojima-san will confirm. He informed
> Synquacer is a brand name.
> 
> Currently no code internally or externally differentiates between
> SC2A11B and Synquacer and we might as well keep living with Synquacer
> only. This patch is an attempt to be accurate.

Then the patch is not correct, because synquacer is not a board. We
should anyway choose only one for adding to documentation.

Best regards,
Krzysztof


  reply	other threads:[~2023-06-20 17:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  3:58 [PATCH] dt-bindings: arm: socionext: add bindings for the Synquacer platform jaswinder.singh
2023-06-16 10:15 ` Krzysztof Kozlowski
2023-06-16 13:12   ` Jassi Brar
2023-06-16 10:15 ` Krzysztof Kozlowski
2023-06-16 16:23   ` Jassi Brar
2023-06-16 16:47     ` Krzysztof Kozlowski
2023-06-16 20:06       ` Jassi Brar
2023-06-16 20:34         ` Krzysztof Kozlowski
2023-06-16 23:18           ` Jassi Brar
2023-06-17  7:18             ` Krzysztof Kozlowski
2023-06-19 19:17               ` Jassi Brar
2023-06-20  6:27                 ` Krzysztof Kozlowski
2023-06-20 16:50 ` Rob Herring
2023-06-20 17:08   ` Jassi Brar
2023-06-20 17:07 ` [PATCHv2] dt-bindings: arm: socionext: add Synquacer platforms jaswinder.singh
2023-06-20 17:16   ` Krzysztof Kozlowski
2023-06-20 17:24     ` Jassi Brar
2023-06-20 17:54       ` Krzysztof Kozlowski [this message]
2023-06-20 18:21         ` Jassi Brar
2023-06-21 15:36   ` [PATCHv3] " jaswinder.singh
2023-06-22  2:01     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dce591cb-ee6c-15cf-e5aa-6b2dc739984a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahisa.kojima@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome