From: Michal Simek <monstr@monstr.eu>
To: Adrian McMenamin <lkmladrian@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Microblaze arch/microblaze/kernel/head.S: redundant code?
Date: Fri, 31 Oct 2014 16:23:13 +0100 [thread overview]
Message-ID: <5453A961.6020900@monstr.eu> (raw)
In-Reply-To: <CAN628AFYBxV-ynmQH9No+t+tVz9XnRkgybcpWXEuGj6FKqyBwA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Hi,
On 10/31/2014 04:15 PM, Adrian McMenamin wrote:
> Looking at this code at line 78 (in 3.17 kernel) it has:
>
> mfs r1, rmsr
> msrclr r8, 0
> cmpu r8, r8, r1
>
> But as far as I can see the result of that comparison is never used - the
> comments state it is to test if the msrclr instruction is enabled.
r8 is used when machine_early_init() is called.
r8 is 4th register which is used for passing args based on Microblaze
reference manual.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
parent reply other threads:[~2014-10-31 15:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAN628AFYBxV-ynmQH9No+t+tVz9XnRkgybcpWXEuGj6FKqyBwA@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5453A961.6020900@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmladrian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®