mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: Microblaze arch/microblaze/kernel/head.S: redundant code?
       [not found] <CAN628AFYBxV-ynmQH9No+t+tVz9XnRkgybcpWXEuGj6FKqyBwA@mail.gmail.com>
@ 2014-10-31 15:23 ` Michal Simek
  0 siblings, 0 replies; only message in thread
From: Michal Simek @ 2014-10-31 15:23 UTC (permalink / raw)
  To: Adrian McMenamin, LKML

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Hi,

On 10/31/2014 04:15 PM, Adrian McMenamin wrote:
> Looking at this code at line 78 (in 3.17 kernel) it has:
> 
>     mfs r1, rmsr
>     msrclr r8, 0
>     cmpu r8, r8, r1
> 
> But as far as I can see the result of that comparison is never used - the
> comments state it is to test if the msrclr  instruction is enabled.

r8 is used when machine_early_init() is called.
r8 is 4th register which is used for passing args based on Microblaze
reference manual.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-10-31 15:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAN628AFYBxV-ynmQH9No+t+tVz9XnRkgybcpWXEuGj6FKqyBwA@mail.gmail.com>
2014-10-31 15:23 ` Microblaze arch/microblaze/kernel/head.S: redundant code? Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®