[PATCH] staging: skein: fixed sparse warnings related to static declarations

[PATCH] staging: skein: fixed sparse warnings related to static declarations

[Niklas Svensson]

drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static?
drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static?
drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static?

Signed-off-by: Niklas Svensson <nks@flawful.org>
---
 drivers/staging/skein/skein_generic.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 60d16b6..85bd7d0 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -27,7 +27,7 @@ static int skein256_init(struct shash_desc *desc)
 			SKEIN256_DIGEST_BIT_SIZE);
 }
 
-int skein256_update(struct shash_desc *desc, const u8 *data,
+static int skein256_update(struct shash_desc *desc, const u8 *data,
 			unsigned int len)
 {
 	return skein_256_update((struct skein_256_ctx *)shash_desc_ctx(desc),
@@ -62,7 +62,7 @@ static int skein512_init(struct shash_desc *desc)
 				SKEIN512_DIGEST_BIT_SIZE);
 }
 
-int skein512_update(struct shash_desc *desc, const u8 *data,
+static int skein512_update(struct shash_desc *desc, const u8 *data,
 			unsigned int len)
 {
 	return skein_512_update((struct skein_512_ctx *)shash_desc_ctx(desc),
@@ -97,7 +97,7 @@ static int skein1024_init(struct shash_desc *desc)
 				SKEIN1024_DIGEST_BIT_SIZE);
 }
 
-int skein1024_update(struct shash_desc *desc, const u8 *data,
+static int skein1024_update(struct shash_desc *desc, const u8 *data,
 			unsigned int len)
 {
 	return skein_1024_update((struct skein_1024_ctx *)shash_desc_ctx(desc),
-- 
2.1.0

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

[Jason Cooper]

On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote:
> drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static?
> drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static?
> drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static?
> 
> Signed-off-by: Niklas Svensson <nks@flawful.org>
> ---
>  drivers/staging/skein/skein_generic.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

What tree/tag is this patch against?  There've been quite a few changes
to the api this time around.

thx,

Jason.

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

[Niklas Svensson]

On 11/08/2014 08:56 PM, Jason Cooper wrote:
> On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote:
>> drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static?
>> drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static?
>> drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static?
>>
>> Signed-off-by: Niklas Svensson <nks@flawful.org>
>> ---
>>  drivers/staging/skein/skein_generic.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
> What tree/tag is this patch against?  There've been quite a few changes
> to the api this time around.
linux-next,
tag: next-20141106

also applicable for gregkg's staging-next tree

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

[Jason Cooper]

On Sun, Nov 09, 2014 at 07:51:36PM +0100, Niklas Svensson wrote:
> 
> On 11/08/2014 08:56 PM, Jason Cooper wrote:
> > On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote:
> >> drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static?
> >> drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static?
> >> drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static?
> >>
> >> Signed-off-by: Niklas Svensson <nks@flawful.org>
> >> ---
> >>  drivers/staging/skein/skein_generic.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> > What tree/tag is this patch against?  There've been quite a few changes
> > to the api this time around.
> >
> linux-next,
> tag: next-20141106
> 
> also applicable for gregkg's staging-next tree

Perfect.

Acked-by: Jason Cooper <jason@lakedaemon.net>

thx,

Jason.