Re: BUG in scsi_lib.c due to a bad commit

[Barto <mister.freeman@laposte.net>]

Hello Christoph,

> Please explicitly test commits:
>
> 71e75c97f97a9645d25fbf3d8e4165a558f18747

with commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 there is no problem


> and
>
> 74665016086615bbaa3fa6f83af410a0a4e029ee

it's interesting, with this commit
74665016086615bbaa3fa6f83af410a0a4e029ee I have the bug :

scsi: convert host_busy to atomic_t :

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=74665016086615bbaa3fa6f83af410a0a4e029ee

Le 13/11/2014 18:54, Christoph Hellwig a écrit :
> On Thu, Nov 13, 2014 at 06:14:14PM +0100, Barto wrote:
>> Hello Christoph,
>>
>> I tested this commit :
>>
>> 7ae65c0f9646c29432b69580b80e08632e6cd813 scsi: convert target_busy to an
>> atomic_t
>>
>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7ae65c0f9646c29432b69580b80e08632e6cd813
>>
>> there is no bug, boot process is ok whit this commit,
>>
>> when I did the "git bisect" the first bad commit was Guenters' commit (
>> 045065d8a300a37218c548e9aa7becd581c6a0e8 ), it seems that all commits
>> before 045065d8a300a37218c548e9aa7becd581c6a0e8 are ok,
> 
> The bisect isn't quite interesting here as we're trying to find the real
> root ause.
> 
> 045065d8a300a37218c548e9aa7becd581c6a0e8 reverts the polarity of the
> check that 71e75c97f97a9645d25fbf3d8e4165a558f18747 incorrectly
> chaged.
> 
> The behavior you see doesn't make a lot of sense from a high level view,
> so we need to find out what's going on.
> 
> When you say all commits before 045065d8a300a37218c548e9aa7becd581c6a0e8
> I wonder if the bisect simply skiped to many revisions.
> 
> Please explicitly test commits:
> 
> 71e75c97f97a9645d25fbf3d8e4165a558f18747
> 
> and
> 
> 74665016086615bbaa3fa6f83af410a0a4e029ee
> 
> Thanks!
> 
>