From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>, nab@linux-iscsi.org
Cc: sagig@mellanox.com, cvubrugier@yahoo.fr, joern@logfs.org,
steven.allen@purestorage.com, arshad.hussain@calsoftinc.com,
agrover@redhat.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iscsi-target: fix error path in iscsi_target_init_module()
Date: Sun, 30 Nov 2014 18:30:51 +0200 [thread overview]
Message-ID: <547B463B.6060001@dev.mellanox.co.il> (raw)
In-Reply-To: <1417345211-5583-1-git-send-email-LinoSanfilippo@gmx.de>
On 11/30/2014 1:00 PM, Lino Sanfilippo wrote:
> In iscsi_target_init_module() unwind transport protocol registration in case
> that iscsit_load_discovery_tpg() failed.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
> drivers/target/iscsi/iscsi_target.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 73e58d2..f8ec322 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -609,6 +609,7 @@ static int __init iscsi_target_init_module(void)
>
> return ret;
> r2t_out:
> + iscsit_unregister_transport(&iscsi_target_transport);
> kmem_cache_destroy(lio_r2t_cache);
> ooo_out:
> kmem_cache_destroy(lio_ooo_cache);
>
Yep, Looks good.
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
next prev parent reply other threads:[~2014-11-30 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 11:00 Lino Sanfilippo
2014-11-30 16:30 ` Sagi Grimberg [this message]
2014-12-02 6:11 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547B463B.6060001@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=LinoSanfilippo@gmx.de \
--cc=agrover@redhat.com \
--cc=arshad.hussain@calsoftinc.com \
--cc=cvubrugier@yahoo.fr \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=steven.allen@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome