* [PATCH] iscsi-target: fix error path in iscsi_target_init_module()
@ 2014-11-30 11:00 Lino Sanfilippo
2014-11-30 16:30 ` Sagi Grimberg
2014-12-02 6:11 ` Nicholas A. Bellinger
0 siblings, 2 replies; 3+ messages in thread
From: Lino Sanfilippo @ 2014-11-30 11:00 UTC (permalink / raw)
To: nab
Cc: sagig, cvubrugier, joern, steven.allen, arshad.hussain, agrover,
linux-scsi, target-devel, linux-kernel, Lino Sanfilippo
In iscsi_target_init_module() unwind transport protocol registration in case
that iscsit_load_discovery_tpg() failed.
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
---
drivers/target/iscsi/iscsi_target.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 73e58d2..f8ec322 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -609,6 +609,7 @@ static int __init iscsi_target_init_module(void)
return ret;
r2t_out:
+ iscsit_unregister_transport(&iscsi_target_transport);
kmem_cache_destroy(lio_r2t_cache);
ooo_out:
kmem_cache_destroy(lio_ooo_cache);
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iscsi-target: fix error path in iscsi_target_init_module()
2014-11-30 11:00 [PATCH] iscsi-target: fix error path in iscsi_target_init_module() Lino Sanfilippo
@ 2014-11-30 16:30 ` Sagi Grimberg
2014-12-02 6:11 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2014-11-30 16:30 UTC (permalink / raw)
To: Lino Sanfilippo, nab
Cc: sagig, cvubrugier, joern, steven.allen, arshad.hussain, agrover,
linux-scsi, target-devel, linux-kernel
On 11/30/2014 1:00 PM, Lino Sanfilippo wrote:
> In iscsi_target_init_module() unwind transport protocol registration in case
> that iscsit_load_discovery_tpg() failed.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
> drivers/target/iscsi/iscsi_target.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 73e58d2..f8ec322 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -609,6 +609,7 @@ static int __init iscsi_target_init_module(void)
>
> return ret;
> r2t_out:
> + iscsit_unregister_transport(&iscsi_target_transport);
> kmem_cache_destroy(lio_r2t_cache);
> ooo_out:
> kmem_cache_destroy(lio_ooo_cache);
>
Yep, Looks good.
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iscsi-target: fix error path in iscsi_target_init_module()
2014-11-30 11:00 [PATCH] iscsi-target: fix error path in iscsi_target_init_module() Lino Sanfilippo
2014-11-30 16:30 ` Sagi Grimberg
@ 2014-12-02 6:11 ` Nicholas A. Bellinger
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas A. Bellinger @ 2014-12-02 6:11 UTC (permalink / raw)
To: Lino Sanfilippo
Cc: sagig, cvubrugier, joern, steven.allen, arshad.hussain, agrover,
linux-scsi, target-devel, linux-kernel
On Sun, 2014-11-30 at 12:00 +0100, Lino Sanfilippo wrote:
> In iscsi_target_init_module() unwind transport protocol registration in case
> that iscsit_load_discovery_tpg() failed.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
> drivers/target/iscsi/iscsi_target.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 73e58d2..f8ec322 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -609,6 +609,7 @@ static int __init iscsi_target_init_module(void)
>
> return ret;
> r2t_out:
> + iscsit_unregister_transport(&iscsi_target_transport);
> kmem_cache_destroy(lio_r2t_cache);
> ooo_out:
> kmem_cache_destroy(lio_ooo_cache);
Nice catch. Applied to target-pending/for-next.
Thanks Lino!
--nab
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-02 6:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-30 11:00 [PATCH] iscsi-target: fix error path in iscsi_target_init_module() Lino Sanfilippo
2014-11-30 16:30 ` Sagi Grimberg
2014-12-02 6:11 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome