mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Abdun Nihaal <nihaal@cse.iitm.ac.in>, <andrew+netdev@lunn.ch>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH net] liquidio: Fix possible memory leak in lio_reset_queues()
Date: Mon, 27 Jul 2026 15:55:28 -0700	[thread overview]
Message-ID: <54804d01-9254-4482-a0be-c38c3c6177b8@intel.com> (raw)
In-Reply-To: <20260727080258.86279-1-nihaal@cse.iitm.ac.in>

On 7/27/2026 1:02 AM, Abdun Nihaal wrote:
> The memory allocated in lio_setup_glists() and setup_rx_oom_poll_fn() is
> not freed in some of the error paths in lio_reset_queues().
> Fix that by adding the corresponding free functions to the error paths.
> 
> Fixes: 4b6e326b2d34 ("liquidio: Per queue oom work queue")
> Cc: stable@vger.kernel.org
> Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
> ---
> Compile tested only. Issue found using static analysis.
> 

Would be nice if we had a reproduction but I suspect this is tricky to
do without some kind of fault injection.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> index c849e2c871a9..222ef0b661da 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> @@ -1242,15 +1242,20 @@ static int lio_reset_queues(struct net_device *netdev, uint32_t num_qs)
>  
>  		if (setup_rx_oom_poll_fn(netdev)) {
>  			dev_err(&oct->pci_dev->dev, "lio_setup_rx_oom_poll_fn failed\n");
> +			lio_delete_glists(lio);
>  			return 1;
>  		}
>  
>  		/* Send firmware the information about new number of queues
>  		 * if the interface is a VF or a PF that is SRIOV enabled.
>  		 */
> -		if (oct->sriov_info.sriov_enabled || OCTEON_CN23XX_VF(oct))
> -			if (lio_send_queue_count_update(netdev, num_qs))
> +		if (oct->sriov_info.sriov_enabled || OCTEON_CN23XX_VF(oct)) {
> +			if (lio_send_queue_count_update(netdev, num_qs)) {
> +				cleanup_rx_oom_poll_fn(netdev);
> +				lio_delete_glists(lio);
>  				return -1;
> +			}
> +		}
>  	}
>  
>  	return 0;


  reply	other threads:[~2026-07-27 22:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  8:02 Abdun Nihaal
2026-07-27 22:55 ` Jacob Keller [this message]
2026-07-30 11:02   ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54804d01-9254-4482-a0be-c38c3c6177b8@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nihaal@cse.iitm.ac.in \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®