mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
	Abdun Nihaal <nihaal@cse.iitm.ac.in>,
	andrew+netdev@lunn.ch
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net] liquidio: Fix possible memory leak in lio_reset_queues()
Date: Thu, 30 Jul 2026 13:02:08 +0200	[thread overview]
Message-ID: <9da84225-3d4c-4dd2-ac77-192ab0f3c03b@redhat.com> (raw)
In-Reply-To: <54804d01-9254-4482-a0be-c38c3c6177b8@intel.com>

On 7/28/26 12:55 AM, Jacob Keller wrote:
> On 7/27/2026 1:02 AM, Abdun Nihaal wrote:
>> The memory allocated in lio_setup_glists() and setup_rx_oom_poll_fn() is
>> not freed in some of the error paths in lio_reset_queues().
>> Fix that by adding the corresponding free functions to the error paths.
>>
>> Fixes: 4b6e326b2d34 ("liquidio: Per queue oom work queue")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
>> ---
>> Compile tested only. Issue found using static analysis.
>>
> 
> Would be nice if we had a reproduction but I suspect this is tricky to
> do without some kind of fault injection.

We are actually requesting such info, especially for patch touching less
active device drivers.

Also sashiko has a bit to say:

https://sashiko.dev/#/patchset/20260727080258.86279-1-nihaal%40cse.iitm.ac.in

/P


      reply	other threads:[~2026-07-30 11:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  8:02 Abdun Nihaal
2026-07-27 22:55 ` Jacob Keller
2026-07-30 11:02   ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9da84225-3d4c-4dd2-ac77-192ab0f3c03b@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nihaal@cse.iitm.ac.in \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®