* [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM
@ 2015-01-06 2:54 dann frazier
2015-01-06 20:03 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: dann frazier @ 2015-01-06 2:54 UTC (permalink / raw)
To: linux-api; +Cc: linux-kernel, Shuah Khan, Doug Ledford
We can't use a char type to check for a negative return value since char
isn't guaranteed to be signed. Indeed, the char type tends to be unsigned on
ARM.
Signed-off-by: dann frazier <dann.frazier@canonical.com>
---
tools/testing/selftests/mqueue/mq_perf_tests.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
index 94dae65..8519e9e 100644
--- a/tools/testing/selftests/mqueue/mq_perf_tests.c
+++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
@@ -536,10 +536,9 @@ int main(int argc, char *argv[])
{
struct mq_attr attr;
char *option, *next_option;
- int i, cpu;
+ int i, cpu, rc;
struct sigaction sa;
poptContext popt_context;
- char rc;
void *retval;
main_thread = pthread_self();
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM
2015-01-06 2:54 [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM dann frazier
@ 2015-01-06 20:03 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2015-01-06 20:03 UTC (permalink / raw)
To: dann frazier, linux-api; +Cc: linux-kernel, Shuah Khan, Doug Ledford
On 01/05/2015 07:54 PM, dann frazier wrote:
> We can't use a char type to check for a negative return value since char
> isn't guaranteed to be signed. Indeed, the char type tends to be unsigned on
> ARM.
>
> Signed-off-by: dann frazier <dann.frazier@canonical.com>
> ---
> tools/testing/selftests/mqueue/mq_perf_tests.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
> index 94dae65..8519e9e 100644
> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
> @@ -536,10 +536,9 @@ int main(int argc, char *argv[])
> {
> struct mq_attr attr;
> char *option, *next_option;
> - int i, cpu;
> + int i, cpu, rc;
> struct sigaction sa;
> poptContext popt_context;
> - char rc;
> void *retval;
>
> main_thread = pthread_self();
>
Thanks. Applied to kernel/git/shuah/linux-kselftest fixes branch
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-06 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-06 2:54 [PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM dann frazier
2015-01-06 20:03 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome