* Re: [PATCH] media; firewire: Remove no longer needed fix me comment in firedtv-ci.c for the function,fdtv_ca_ioctl
[not found] <1420838221-3957-1-git-send-email-xerofoify@gmail.com>
@ 2015-01-09 23:02 ` Clemens Ladisch
0 siblings, 0 replies; only message in thread
From: Clemens Ladisch @ 2015-01-09 23:02 UTC (permalink / raw)
To: Nicholas Krause, stefanr
Cc: linux-media, linux1394-devel, linux-kernel, mchehab
Nicholas Krause wrote:
> Removes the no longer fix me comment for if we need to set the tuner status with
> the line, avc_tuner_status(fdtv, &stat). This line is needed in order to set the
> tuner status after we have through the switch statement checking what fdtv function
> we need to call to use to try and setup the hardware successfully.
You have attempted to describe what fdtv_ca_ioctl() does, but your description
lacks any understanding of what avc_tuner_status() does, or how it might affect
the device, or whether it is necessary.
Please stop spamming us with useless patches.
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/media/firewire/firedtv-ci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/firewire/firedtv-ci.c b/drivers/media/firewire/firedtv-ci.c
> index e63f582..9c038ba 100644
> --- a/drivers/media/firewire/firedtv-ci.c
> +++ b/drivers/media/firewire/firedtv-ci.c
> @@ -201,7 +201,6 @@ static int fdtv_ca_ioctl(struct file *file, unsigned int cmd, void *arg)
> err = -EOPNOTSUPP;
> }
>
> - /* FIXME Is this necessary? */
> avc_tuner_status(fdtv, &stat);
>
> return err;
^ permalink raw reply [flat|nested] only message in thread