mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Arnaldo Carvalho de Melo" <acme@redhat.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: your recent tools/include/ adjustments
Date: Tue, 13 Jan 2015 08:48:35 +0000	[thread overview]
Message-ID: <54B4E9F3020000780005427E@mail.emea.novell.com> (raw)

Arnaldo,

considering that tools/include/ gets used by other than just perf, in
particular arch/x86/vdso/vdso2c.c, would you mind clarifying how
"tools: Move bitops.h from tools/perf/util to tools/" adding an
inclusion of asm/hweight.h to linux/bitops.h is supposed to work,
when the only potentially relevant header to be found is
tools/perf/util/include/asm/hweight.h?

Similarly, with "tools: Adopt fls_long and deps" adding 3 stub
headers to tools/include/asm-generic/bitops/ using
"#include <../../../../include/asm-generic/bitops/...>", I can't
see how these headers are to be found when building the above
mentioned utility - I suppose these really were meant to use
quotes instead of angle brackets.

For reference, the breakage was observed on a relatively old
x86 system where linux/elf.h includes asm/elf.h, reaching
linux/bitops.h via asm/system.h and asm/cpufeature.h.

Thanks for any insight/clarification,
Jan


             reply	other threads:[~2015-01-13  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  8:48 Jan Beulich [this message]
2015-01-13 13:29 ` Arnaldo Carvalho de Melo
2015-01-13 15:56   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B4E9F3020000780005427E@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®